451529 - Deleting invitation copy sends out CANCEL to all attendees

Status: VERIFIED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Daniel Boelzle [:dbo]]

1. Accept an iTIP invitation.
2. Delete the invitation copy form calendar.
3. CANCEL is sent out to all attendees.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

This patch fixes the bug:
* sends out a REPLY/DECLINED in case the user deletes the invitation copy

moreover:
* makes X-MOZ-SEND-INVITATION to be specific to sending out REQUEST messages (for organizer only) and transport-agnostic
* removes some redundant checks
* fixes invitation dialog's organizer line in case no common name is available
* fixes invitation dialog to exclude invitation to self (organizer in attendees list)

Comment 2

[Stefan Sitter [:ssitter]]

Isn't that on purpose? See Bug 429938.

Comment 3

[Daniel Boelzle [:dbo]]

Different scope:
If the organizer deletes the event, a CANCEL should be sent out to all attendees (bug 429938).
If an attendee deletes her invitations copy, no CANCEL must be sent to all attendees(, but a REPLY/DECLINED is sensible to be sent to the organizer).

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 334855 [details] [diff] [review]
fix - v1

r=philipp

Comment 5

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Comment 6

[Hubert FONGARNAND]

It seems it doesn't work on a caldav calendar

Comment 7

[Daniel Boelzle [:dbo]]

Hubert, could you please elaborate what doesn't work?

Comment 8

[Stefan Sitter [:ssitter]]

Hubert, please ensure that you are using a nightly build that contains the changes (20080822xx or newer). Also see Bug 451696.

Comment 9

[Hubert FONGARNAND]

With the caldav calendar a CANCEL is sent out to all attendees when i delete the event...

1. Accept an iTIP invitation.
2. Delete the invitation copy form calendar.
3. CANCEL is sent out to all attendees.

Comment 10

[Hubert FONGARNAND]

aItem.calendar.isInvitation(aItem) return false in chrome://calendar/content/calendar-item-editing.js line 483 

because aItem.getProperty("organizerId") is null

Comment 11

[Andreas Treumann]

I checked this issue with lightning build 2008082518 and the CANCEL is sent only to the organizer -> WFM.

Comment 12

[Daniel Boelzle [:dbo]]

(In reply to comment #10)
> because aItem.getProperty("organizerId") is null
Which indicates that your caldav server either does not support scheduling or it doesn't provide a calendar-user-address.

Comment 13

[Hubert FONGARNAND]

forget my comments, it was a bug in my caldav server

Comment 14

[Andreas Treumann]

Checked in lightning 2008082620 -> VERIFIED.