Closed Bug 451601 Opened 12 years ago Closed 12 years ago

kill MOZILLA_LOCALE_VERSION

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(5 files)

The lang.version entity as in http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/branding/brand.dtd#1 is not used any more but there are multiple mentionings of MOZILLA_LOCALE_VERSION still around in the tree, see http://mxr.mozilla.org/comm-central/search?string=MOZILLA_LOCALE_VERSION

We should remove those that are not needed any more, i.e. the contents.rdf files in mozilla-central, etc.
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
This is the mozilla-central part, removing all the chrome-versions that were only needed by the old chrome registry which has died as well now. The occurrences I've not killed should be covered by the patches in bug 451909.
Attachment #336276 - Flags: superreview?(neil)
Attachment #336276 - Flags: review?(ted.mielczarek)
This is the comm-central part - not much to do here actually :)
Attachment #336277 - Flags: review?(bugzilla)
DOMi still builds a contents.rdf, but only for the locale, not for anything else, even though that's unneeded as the manifest entry take precedence anyway.
Attachment #336279 - Flags: review?(sdwilsh)
Comment on attachment 336276 [details] [diff] [review]
mozilla-central patch to kill those chrome versions

>diff --git a/xpfe/components/download-manager/resources/Makefile.in b/xpfe/components/download-manager/resources/Makefile.in
>-ifneq (,$(filter OS2 WINNT WINCE,$(OS_ARCH)))
>-DIRS		= win
>-else
> ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
> DIRS		= mac
> else
>-DIRS		= unix
>-endif
>-endif

Oops, that should be an endif that gets left over instead of the else.
This removes that stuff from ChatZilla - the make*xpi.sh scripts have set it to empty all the time anyway, so just do that by default for the contents.rdf files (and the new manifest stuff doesn't need it at all).
Attachment #336295 - Flags: review?
Attachment #336295 - Flags: review? → review?(silver)
And here's the venkman patch - as for ChatZilla, we were setting this to empty for the make*xpi.sh scripts all the time, so we're coding contents.rdf to have it like that by default.
Attachment #336298 - Flags: review?
Attachment #336298 - Flags: review? → review?(ajvincent)
Attachment #336298 - Flags: review?(ajvincent) → review+
Comment on attachment 336298 [details] [diff] [review]
venkman patch (checked in)

Looks good to me.
Attachment #336276 - Flags: superreview?(neil) → superreview+
Attachment #336277 - Flags: review?(bugzilla) → review+
Comment on attachment 336277 [details] [diff] [review]
comm-central patch (checked in)

You should also remove the preprocess '*' from the start of the brand.dtd line in suite/locales/jar.mn.

r=me with that fixed.
Comment on attachment 336277 [details] [diff] [review]
comm-central patch (checked in)

Pushed as http://hg.mozilla.org/comm-central/rev/effeccdba665
Attachment #336277 - Attachment description: comm-central patch → comm-central patch (checked in)
Comment on attachment 336298 [details] [diff] [review]
venkman patch (checked in)

checked in the venkman part as well (in cvs trunk).
Attachment #336298 - Attachment description: venkman patch → venkman patch (checked in)
Attachment #336276 - Flags: review?(ted.mielczarek) → review+
Attachment #336295 - Flags: review?(silver) → review?(gijskruitbosch+bugs)
Comment on attachment 336295 [details] [diff] [review]
ChatZilla patch (checked in)

r=me
Attachment #336295 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 336279 [details] [diff] [review]
DOMi patch (checked in)

r=sdwilsh; I'm waiving the sr requirement for this patch.
Attachment #336279 - Flags: review?(sdwilsh) → review+
Comment on attachment 336295 [details] [diff] [review]
ChatZilla patch (checked in)

Checked in the ChatZilla part on cvs trunk.
Attachment #336295 - Attachment description: ChatZilla patch → ChatZilla patch (checked in)
Comment on attachment 336279 [details] [diff] [review]
DOMi patch (checked in)

DOMi part pushed as http://hg.mozilla.org/dom-inspector/rev/213755b60af8
Attachment #336279 - Attachment description: DOMi patch → DOMi patch (checked in)
Main mozilla-central part pushed as http://hg.mozilla.org/mozilla-central/rev/122c2763549f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.