451830 - Firefox 2 major update screen issues for Hebrew/RTL

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tomer Cohen :tomer]

Attachment: screenshot (Ubuntu Linux 8.04)

We did some testing on the new major update screen, and unfortunately found some issues affecting Hebrew but not the tier 1 locales. 

Steps to reproduce:
a. Install Firefox 2.
b. Change the update channel to beta (filename defaults/pref/channel-prefs.js).
c. Launch Firefox 2 (preferable on a profile other than the one you use for Firefox 3), and watch for the major update screen.

Current results: 
* All platforms - bullets appear at the left side instead of the right side (actually I added dir=rtl to the HTML file - bug 451128 comment 24).
* Horizontal scrollbar appear on Linux and Vista.
* Vertical scrollbar appears on Windows Vista and OSX. 
* Vertical scrollbar is not aligned correctly in Vista.
* Firefox logo appears cropped on Vista (This might be due to the vertical scrollbar)

Comment 1

[Tomer Cohen :tomer]

Attachment: screenshot (Windows Vista)

Comment 2

[Yehuda]

Attachment: Screenshot Mac OS X 10.4

Mac dialog also shows a vertical scroll, and bullets on the left hand side.

Comment 3

[Yehuda]

The bullets issue can be fixed by adding the following lines to the header of https://bugzilla.mozilla.org/attachment.cgi?id=334442

<style type="text/css">
	#details-content  li {
		background: none;
	}
	#details-content ul {
		list-style-image:url(/img/tignish/content/bullet.png);
	}
</style>

Comment 4

[Yehuda]

(In reply to comment #3)
my suggestion in the above comment had an error in Firefox 2. Here is another take that looks the same (and looks good) in Firefox 2 and Firefox 3:
<style type="text/css">
	#details-content ul li {
		margin-right: 0px;
		margin-left: 0px;
		background: none;
	}
	#details-content ul  {
		padding-right:35px;
		list-style-image:url(/img/tignish/content/bullet.png);
	}
</style>

Comment 5

[Pascal Chevrel:pascalc]

http://l10n.mozilla.org/~pascalc/firefox3migration/display2.php?loc=he

I think it looks better now although this is not shown in the real context of the upgrading box, Tomer, Yahuda, if you have the opportunity to do it, could you test confirm that it is ok now ? Thanks

Comment 6

[Tomer Cohen :tomer]

Attachment: screenshot (Ubuntu Linux 8.04)

Looks fine under Linux (Please note the scrollbar. Can we get rid of it?)

Comment 7

[Tomer Cohen :tomer]

Attachment: screenshot (Windows XP)

Windows XP has both horizontal and vertical scrollbars and the cropped text which is not the expected result. I don't have access the Vista at the moment, but I afraid the scrollbars issue still exists there.

Comment 8

[Yehuda]

Attachment: Screenshot Mac OS X 10.4

Mac OS X looks better now. The bullets are in the correct place, and although the vertical scrollbar still exists, it does not seem to cause any issues with the display.

Comment 9

[Pascal Chevrel:pascalc]

we have updated the styles for hebrew to minimize paddings and margins as much as possible:
http://he.www.mozilla.com/he/firefox/3.0/details/

Tell me if it looks acceptable now, I am not sure I can get something better without us actually redoing the whole content, we are really targetting "good enough" on this one.

Thanks

Comment 10

[Tomer Cohen :tomer]

Attachment: screenshot (Ubuntu Linux 8.04)

Looks fine for me.

Comment 11

[Yehuda]

Attachment: Screenshot Mac OS X 10.4

Still a few pixels short for Mac OS X, so the vertical scrollbar is there, but at least all the text can be read without scrolling. I guess it can be counted as "good enough".

Comment 12

[Pascal Chevrel:pascalc]

thanks guys, let's resolve it as fixed then