Closed
Bug 451918
Opened 16 years ago
Closed 12 years ago
Remove |APP_XPCOM_LIBS| from /browser/
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla6
People
(Reporter: sgautherie, Assigned: Swatinem)
References
()
Details
(Whiteboard: [Fixed by bug 648911])
Attachments
(1 obsolete file)
Port |Bug 451871 – Remove |MOZILLA_INTERNAL_API| from /suite/| to Firefox.
Assignee | ||
Comment 1•16 years ago
|
||
small patch to do the job.
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attachment #335506 -
Flags: review?(ted.mielczarek)
Updated•16 years ago
|
Attachment #335506 -
Flags: review?(ted.mielczarek) → review?(benjamin)
Updated•16 years ago
|
Attachment #335506 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 2•16 years ago
|
||
Note: bug 451871 got backed out because of tracemalloc bustage.
Reporter | ||
Comment 3•16 years ago
|
||
(In reply to comment #2) > Note: bug 451871 got backed out because of tracemalloc bustage. True, yet: *The SM bustage still needs to be "confirmed" / narrowed down. *Isn't Firefox already using |MOZ_ENABLE_LIBXUL| anyway ?
Depends on: 345517
Comment 4•16 years ago
|
||
Yes, but it's possible to build --disable-libxul, and debug builds disable libxul by default. (And tracemalloc probably doesn't work with libxul anyway.)
Reporter | ||
Comment 5•16 years ago
|
||
(In reply to comment #4) > Yes, but it's possible to build --disable-libxul, and debug builds disable libxul by default. Ah... (Looking forward to "libxul only" (Firefox) ;->) Then, someone needs to check a debug Firefox build. Note that a debug SeaMonkey (without trace-malloc) build works fine with "this" patch. > (And tracemalloc probably doesn't work with libxul anyway.) Fwiw, as far as compiling and generating the logs, it works fine on my Windows (libxul SeaMonkey).
Comment 6•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6772511dc81a
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
Reporter | ||
Updated•16 years ago
|
Attachment #335506 -
Attachment description: patch → patch
[Checkin: Comment 6]
Reporter | ||
Updated•16 years ago
|
Severity: normal → trivial
Flags: in-testsuite-
Comment 7•16 years ago
|
||
Just backed this out, to see if it fixes bug 455095. (linux leak stats mysteriously all going to 0) Backout was http://hg.mozilla.org/mozilla-central/rev/9d9569916616
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•16 years ago
|
Attachment #335506 -
Attachment description: patch
[Checkin: Comment 6] → patch
[Backout: Comment 7]
Comment 8•12 years ago
|
||
This got fixed a while ago by bug 648911
Status: REOPENED → RESOLVED
Closed: 16 years ago → 12 years ago
Depends on: 648911
Resolution: --- → FIXED
Whiteboard: [Fixed by bug 648911]
Reporter | ||
Updated•12 years ago
|
Attachment #335506 -
Attachment description: patch
[Backout: Comment 7] → patch
[Superseded by bug 648911]
Attachment #335506 -
Attachment is obsolete: true
Reporter | ||
Comment 9•12 years ago
|
||
V.Fixed
Status: RESOLVED → VERIFIED
Target Milestone: Firefox 3.1b1 → Firefox 6
Updated•5 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•5 years ago
|
Target Milestone: Firefox 6 → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•