451918 - Remove |APP_XPCOM_LIBS| from /browser/

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

Port |Bug 451871 – Remove |MOZILLA_INTERNAL_API| from /suite/| to Firefox.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: patch [Superseded by bug 648911]

small patch to do the job.

Comment 2

[Mark Banner (:standard8)]

Note: bug 451871 got backed out because of tracemalloc bustage.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Note: bug 451871 got backed out because of tracemalloc bustage.

True, yet:
*The SM bustage still needs to be "confirmed" / narrowed down.
*Isn't Firefox already using |MOZ_ENABLE_LIBXUL| anyway ?

Comment 4

[(not currently active) Ted Mielczarek]

Yes, but it's possible to build --disable-libxul, and debug builds disable libxul by default. (And tracemalloc probably doesn't work with libxul anyway.)

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Yes, but it's possible to build --disable-libxul, and debug builds disable libxul by default.

Ah... (Looking forward to "libxul only" (Firefox) ;->)

Then, someone needs to check a debug Firefox build.
Note that a debug SeaMonkey (without trace-malloc) build works fine with "this" patch.

> (And tracemalloc probably doesn't work with libxul anyway.)

Fwiw, as far as compiling and generating the logs, it works fine on my Windows (libxul SeaMonkey).

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/6772511dc81a

Comment 7

[Daniel Holbert [:dholbert]]

Just backed this out, to see if it fixes bug 455095. (linux leak stats mysteriously all going to 0)

Backout was http://hg.mozilla.org/mozilla-central/rev/9d9569916616

Comment 8

[Mark Banner (:standard8)]

This got fixed a while ago by bug 648911

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed