451937 - Titlebar changes to text of Calendar Mode at midnight

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Pete Riley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16
Build Identifier: Lightning 0.9pre 2008-08-21 18 / Thunderbird 2.0.0.16

The titlebar changes to the text of Calendar Mode at midnight even though Thunderbird is in Mail Mode.

Reproducible: Always

Actual Results:  
"August 2008 - Thunderbird"

Expected Results:  
"Inbox - Thunderbird"

Perhaps related to bug 448205.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

In this patch I added a verification that the document title is only set when the application is in calendar mode. I give it a final test till tomorrow before asking for review. I thought about whether we should solve this problem in a more general way than I did, but in Taskmode the application title is only a constant string not being affected by the midnight update. So I saw no need for it at the moment.

Comment 2

[Berend Cornelius]

Comment on attachment 335712 [details] [diff] [review]
patch v. #1

As me and Andreas tested this patch seems to work fine.

Comment 3

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH
-> FIXED

Comment 4

[Pete Riley]

I confirmed that the titlebar doesn't change at midnight.  Thanks!

Lightning 0.9pre 2008-08-31 20

Comment 5

[Daniel Boelzle [:dbo]]

VERIFIED per comment #4