Closed
Bug 45225
Opened 25 years ago
Closed 25 years ago
When opening an attachment, you get 2 dialogs
Categories
(MailNews Core :: Backend, defect, P2)
MailNews Core
Backend
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.8
People
(Reporter: mscott, Assigned: mscott)
References
Details
(Whiteboard: [nsbeta1+])
Attachments
(1 file)
959 bytes,
patch
|
Details | Diff | Splinter Review |
If you try to open an attachment by clicking on the attachment icon, you will
now see:
1) a mailnews dialog asking you if you want to open or save the attachment.
If you click on open, you will later on get:
2) the helper app dialog saying; Do you want to open or save the attachment.
This is because the helper app dialog doesn't know the user has already seen the
mailnews dialog.
I wouldn't hold nsbeta2 for this. nsbeta3.
changing qa assigned to pmock. (my bug :) )
QA Contact: lchiang → pmock
P1 per mail triage.
per selmer, there are some bad things about this? I don't recall what they
were.
Priority: P3 → P1
Assignee | ||
Comment 4•25 years ago
|
||
I don't think there are any negative side effects other than the fact that you
get two dialogs.
So more of a polish annoyance.
I would actually recommend this as one of the bugs that gets cut from my list
not moved to P1 =).
The solution is going to be hard anyway....
Comment 6•25 years ago
|
||
Uh, OK. I thought Scott had said getting 2 dialogs was very bad. Since he
disclaims that, I'm minusing this.
Whiteboard: [nsbeta3+] → [nsbeta3-][cut 8/29]
I'd like to nominate this for the next release of Netscape 6. The second dialog
gets hidden actually and this makes it confusing to the user to bring that dlg
to the front.
Keywords: nsbeta1
Comment 9•25 years ago
|
||
marking nsbeta1+ and moving to mozilla0.8. How hard will this be to do?
Keywords: nsbeta3
Priority: P1 → P2
Whiteboard: [nsbeta3-][cut 8/29] → [nsbeta1+]
Target Milestone: M18 → mozilla0.8
Assignee | ||
Comment 10•25 years ago
|
||
*** Bug 62083 has been marked as a duplicate of this bug. ***
Comment 12•25 years ago
|
||
Why has this dialog been implemented in the first place?
Is there any condition in which the second dialog might not appear and just open
unconditionally? If so, are we *sure* this is the right behaviour? (We should
not do this for MS Word doocuments, for example, unless the user explicitly told
us to and has been warned about security dangers.)
Why is removing the first dialog hard?
Assignee | ||
Comment 13•25 years ago
|
||
This should make a lot of people happy. I thought this problem was hard to fix
because we didn't know if the user wanted to open or save the attachment when
they clicked on the pop up. So Jefft, made it so we asked them with a mailnews
dialog saying do you want to open or save it? If you clicked open, we would try
to open it (if it was html a browser window would get it). If no one could
handle the content then you got the 2nd dialog used for helper apps which also
had a save to disk button.
If we say clicking on an attachment link is just like clicking on a URL then
this problem becomes MUCH simpler to solve. Just open the URL. Don't do anything
else. That might cause the cotnent to get loaded in a browser window where the
user can click save if they want to save it. Or it might require an exthandler
in which case the user will get the friendly helper app dialog which says Open
or Save.
Attaching the patch to make this behavior happen. I know this double dialog bug
was a real usability complaint.
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9 → mozilla0.8
Assignee | ||
Comment 14•25 years ago
|
||
Oh, there is a Santa Claus!
Assignee | ||
Comment 16•25 years ago
|
||
This change will break the work Jean-Francois checked in yesterday to handle
saving apple double attachments because he added code to the mailnews save
message code that I'm now bypassing.
We are working on a plan for apple double to work with this patch but it will
take some time. So I won't be checking this fix in until we are done with the
apple double work.
Assignee | ||
Comment 18•25 years ago
|
||
Okay Jean-Francois and I worked out the apple double problems (nice job JF!!)
and he's landing that stuff tonight.
So I'm checking in the fix for the extra dialog for opening mail attachments.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 19•24 years ago
|
||
Cannot verify this bug until bug 67435 is fixed.
Comment 20•24 years ago
|
||
Win32 and Mac and Linux (2001-02-12-08 Mtrunk)
This bug is fixed.
Status: RESOLVED → VERIFIED
Comment 21•24 years ago
|
||
> That might cause the cotnent to get loaded in a browser window where the
> user can click save if they want to save it.
Sorry for objecting that late, but I had to see it. This is unfortunate. I tried
to save a png (called sample.png in the mail), but it loaded in a small
pop-browser window. After I realized what happened (most users won't even get
that far), I tried to save it via content menu, and the name
|foldnername>number|, e.g. |INBOX>5|, has been suggested.
Summary of problems:
- Wrong browser window chosen (small pop-up window)
- No option to control the load, e.g. target a *new* browser window
- Wrong default filename
Should I file new a bug or reopen?
Comment 22•24 years ago
|
||
Actually, it was worse: Also found privacy (!)-relevant bug 68682.
> - Wrong browser window chosen (small pop-up window)
On the next try, it chose this very window where I am typing now, i.e. it nearly
caused my comment to be lost.
Personally, I don't know why we load in existing windows at all. IMO, we should
*always* load in new windows, everywhere (e.g. clicking on links in Mailnews).
But maybe that's just subjective. In any case, I need the *option* (in a
comfortable way) to load in a new browser window.
Comment 23•24 years ago
|
||
I think you should open a new bug since the 2 dialogs issue has been fixed.
Updated•21 years ago
|
Product: MailNews → Core
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•