452278 - CSSParserImpl::InitScanner() never fails - remove unnecessary checks

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Zack Weinberg (:zwol)]

Attachment: (rev 1) initial patch

While doing the patch for bug 452275 I noticed that CSSParserImpl::InitScanner() (both overloads) and ::ReleaseScanner() always return NS_OK.  The return value of ::InitScanner was being scrupulously checked by all callers, but that from ::ReleaseScanner was being ignored.  Since none of these are NS_IMETHODs, I just went ahead and made them return void and deleted the error checks in the caller.

This depends on bug 452275 only because the patch was developed on top of it.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 335560 [details] [diff] [review]
(rev 1) initial patch

r+sr=dbaron.  (And it looks like the GatherMedia change addresses one of my review comments on bug 452275, though maybe it should be part of that patch.)

Again, I could land this for you later if you update it.  (Or you could even mail me an hg bundle containing changesets for both of these patches...)

Comment 2

[Zack Weinberg (:zwol)]

Attachment: (rev 2) updated for changes to bug 452275

revised patch.  I did move the GatherMedia error handling change to the first patch in the series.

Comment 3

[Zack Weinberg (:zwol)]

landing seems to have stuck.