Closed Bug 452278 Opened 14 years ago Closed 13 years ago

CSSParserImpl::InitScanner() never fails - remove unnecessary checks

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: zwol, Assigned: zwol)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch (rev 1) initial patch (obsolete) — Splinter Review
While doing the patch for bug 452275 I noticed that CSSParserImpl::InitScanner() (both overloads) and ::ReleaseScanner() always return NS_OK.  The return value of ::InitScanner was being scrupulously checked by all callers, but that from ::ReleaseScanner was being ignored.  Since none of these are NS_IMETHODs, I just went ahead and made them return void and deleted the error checks in the caller.

This depends on bug 452275 only because the patch was developed on top of it.
Attachment #335560 - Flags: superreview?(dbaron)
Attachment #335560 - Flags: review?(dbaron)
Blocks: 443976
Blocks: 452518
Comment on attachment 335560 [details] [diff] [review]
(rev 1) initial patch

r+sr=dbaron.  (And it looks like the GatherMedia change addresses one of my review comments on bug 452275, though maybe it should be part of that patch.)

Again, I could land this for you later if you update it.  (Or you could even mail me an hg bundle containing changesets for both of these patches...)
Attachment #335560 - Flags: superreview?(dbaron)
Attachment #335560 - Flags: superreview+
Attachment #335560 - Flags: review?(dbaron)
Attachment #335560 - Flags: review+
revised patch.  I did move the GatherMedia error handling change to the first patch in the series.
Attachment #335560 - Attachment is obsolete: true
landing seems to have stuck.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.