452518 - encapsulation improvements for nsCSSScanner

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Zack Weinberg (:zwol)]

Attachment: (rev 1) proposed patch

There's a bunch of stuff in nsCSSScanner.h that only nsCSSScanner.cpp needs to see.  Move it there.

Patch is on top of bug 452278.

Comment 1

[Zack Weinberg (:zwol)]

n.b. please ignore the words "and make initialization thread-safe" at the top of the patch; i decided not to do that and forgot to edit the patch header.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 335799 [details] [diff] [review]
(rev 1) proposed patch

r+sr=dbaron if you move the new chunk of methods added to nsCSSScanner.cpp up to right after BuildLexTable, to reduce the risk of having to reorder them later.

And again, the comment in the previous bugs about emailing me an hg bundle still applies.  But remember to fix the commit comment as you described above.

Comment 3

[Zack Weinberg (:zwol)]

Attachment: (rev 2) functions moved as requested

revised patch.

Comment 4

[Alfred Kayser]

P.s. one could replace IsDigit{return PRUint32(ch) < 256 && (gLexTable[ch] & IS_DIGIT) != 0;}
with
IsDigit(return (ch>='0' && ch <='9');}

As that won't require a reference to a table and performing a bit operation on value, just two compares, which is inlined much better.

Comment 5

[Zack Weinberg (:zwol)]

landing seems to have stuck.

Alfred: maybe later.

Comment 6

[Alfred Kayser]

Created bug 483977 for IsDigit simplification.