All users were logged out of Bugzilla on October 13th, 2018

Message Header display shouldn't get the show references pref for each item of the header displayed

RESOLVED FIXED in Thunderbird 3.0a3

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({perf})

Trunk
Thunderbird 3.0a3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 335710 [details] [diff] [review]
The fix

I just noticed this whilst doing the inline edit card bug.

When we display a header, we loop round all the individual elements displayed and do the appropriate things to update them.

As part of that we are working out whether or not to display references - each time round the loop we are getting the value of the pref over the xpcom interface.

Its probably not going to affect us much perf wise, but we still shouldn't be doing it.

I've moved it into a pref observer (which we already have) and updating it from there. As its a hidden pref a MsgReload won't affect us much, but will update the display if something changes.
Attachment #335710 - Flags: review?(bienvenu)

Updated

10 years ago
Attachment #335710 - Flags: review?(bienvenu) → review+
Checked in, changeset: 205:0213040b7ff1
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Blocks: 360488
Ftr, SeaMonkey read this pref in OnLoadMsgHeaderPane() too/only, but doesn't update it after that ... so I change my mind and think there is no (current) need to port this bug to SM.
No longer blocks: 360488
You need to log in before you can comment on or make changes to this bug.