Closed Bug 452426 Opened 15 years ago Closed 15 years ago
.ini should supply mercurial changeset
Parallel to bug 407319, which was only fixed on CVS for date stamps.
Stealing, hope you don't mind!
Assignee: benjamin → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #338238 - Flags: review?(benjamin)
I think this would be super helpful for lots of reasons, not least of all Talos. Thinking about other apps a bit, each could implement something similar in their own application.ini for however many repositories they need. But perhaps we could put a mozilla-central revision into platform.ini ? Then apps using XULRunner/The Platform need only specify their own repo's in application.ini.
This would help a lot when finding possible culprits for regressions. Note also bug 448155.
Comment on attachment 338238 [details] [diff] [review] put changeset id and repo URL in application.ini >+SOURCE_STAMP = $(shell hg identify -i $(topsrcdir)) 1) Use := to avoid calling out to this several times 2) Redirect stderr to /dev/null so that a tarball build (or RPM build, or whatever) doesn't show an unnecessary error message? >diff --git a/browser/app/application.ini b/browser/app/application.ini >+#ifdef MOZ_SOURCE_REPO >+SourceRepository=@MOZ_SOURCE_REPO@ >+#endif >+SourceStamp=@MOZ_SOURCE_STAMP@ Need an ifdef for SourceStamp too, in case someone's building from a tarball. r=me with those changes
Attachment #338238 - Flags: review?(benjamin) → review+
Made the changes that bsmedberg suggested, and added a little sed s/^ssh:/http:/ on the repo path, just to make that nicer. I tested this with a hg repo and with moving my .hg dir out of the way, and both ways looked good. I'm going to land this version of the patch.
Attachment #338238 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.