Closed Bug 494498 Opened 11 years ago Closed 11 years ago

comm-central apps should supply mercurial changeset in application.ini

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

To make L10n repack factories actually know what source was used to build a certain application build, we need to supply its changeset in application.ini. This is a straight port of bug 452426 to comm-central apps.
Here's the straight-forward port of the Firefox patch to all comm-central apps.
Attachment #379263 - Flags: review?
Attachment #379263 - Flags: review? → review?(dmose)
Attachment #379263 - Flags: review?(dmose) → review+
Comment on attachment 379263 [details] [diff] [review]
add changeset to application.ini

>diff --git a/calendar/sunbird/app/Makefile.in b/calendar/sunbird/app/Makefile.in
>--- a/calendar/sunbird/app/Makefile.in
>+++ b/calendar/sunbird/app/Makefile.in
>@@ -63,16 +63,26 @@
> DEFINES += -DAPP_UA_NAME="$(APP_UA_NAME)"
> 
> DIST_FILES = application.ini
> 
> GRE_MILESTONE = $(shell $(PYTHON) $(MOZILLA_SRCDIR)/config/printconfigsetting.py $(LIBXUL_DIST)/bin/platform.ini Build Milestone)
> GRE_BUILDID = $(shell $(PYTHON) $(MOZILLA_SRCDIR)/config/printconfigsetting.py $(LIBXUL_DIST)/bin/platform.ini Build BuildID)
>  
> DEFINES += -DGRE_MILESTONE=$(GRE_MILESTONE) -DGRE_BUILDID=$(GRE_BUILDID)
>+
>+SOURCE_STAMP := $(shell cd $(topsrcdir) ; hg identify 2>/dev/null | cut -f1 -d' ')

Using "hg identify -i" avoids spawning an extra process and makes the code easier to read.

r=dmose with that change.
I did some source digging, found bug 448155 comment #9 and following, and pointed dmose to that. He agreed on IRC to go with my original patch even though working on scratchbox isn't of much importance for us.
Pushed as http://hg.mozilla.org/comm-central/rev/1a25ea0c8358
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.