452891 - The dashed border next to the line numbers in the Diff Viewer can be visually jarring

Status: VERIFIED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Max Kanat-Alexander]

Brendan pointed out that a solid vertical border would be less visually distracting, on the line numbers in the Diff Viewer. It's a small thing, but it sounded like a good idea to me.

Comment 1

[Zack Weinberg (:zwol)]

... do we need vertical lines at all?  The color change would be enough, I think.

Comment 2

[Marc Schumann [:Wurblzap]]

I'm with Zack.

Comment 3

[Brendan Eich [:brendan]]

Me too.

/be

Comment 4

[Max Kanat-Alexander]

If you're going to write that much custom JS, could you look into using YUI for the keyword chooser?

Comment 5

[Max Kanat-Alexander]

Attachment: v1

Wow, you're right, that is much nicer indeed. Thanks for pointing that out, Brendan.

Comment 6

[Marc Schumann [:Wurblzap]]

Ftr and to whom it may concern, comment 4 was meant for bug 452734.

Comment 7

[Max Kanat-Alexander]

tip:

Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v  <--  diff-header.html.tmpl
new revision: 1.19; previous revision: 1.18
done

3.2:

Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v  <--  diff-header.html.tmpl
new revision: 1.18.2.1; previous revision: 1.18
done