Closed
Bug 453180
Opened 17 years ago
Closed 17 years ago
Adding moz_annos_placeattributeindex should be done in migration code not shutdown
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
5.83 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Right now we have a big block of code in nsNavHistory::CleanUpOnQuit that removes an index and adds moz_annos_placeattributeindex on every shutdown (if the old index exists). We can piggy-back off of bug 449640's schema change and do it there.
|
Assignee | |
Comment 1•17 years ago
|
||
Oh how your review queue must love me now...
Attachment #336950 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich]
|
||
Comment 2•17 years ago
|
||
Comment on attachment 336950 [details] [diff] [review]
v1.0
sounds good, r=me
Attachment #336950 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich] → [has patch][has review
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][has review → [has patch][has review]
|
|
Assignee | |
Comment 3•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in
before you can comment on or make changes to this bug.
Description
•