45337 - HTTP channel loses track of SecurityInfo

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[John G. Myers]

Running with the patch attached to bug 31982, my OnStatusChange() handler is
receiving the flag_stop notification for cookie.js after the SecurityInfo for
the channel has been removed.  I need the flag_stop notification while the
nsIChannel::GetSecurityInfo() value previously returned is still there.

Entry at index 0 is https://scopus/bugsplat
1024[8063d60]: SecureUI:874c288: OnStateChange: 70001 :https://scopus/bugsplat
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 10001 :https://scopus/bugsplat/
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 10010 :https://scopus/bugsplat
Opening file 56955828.s failed
WEBSHELL+ = 5
->>>>>>>>>>>>>> Write Clipboard to memory
nsWidget::~nsWidget() of toplevel: 12 widgets still exist.
WEBSHELL- = 4
1024[8063d60]: SecureUI:874c288: OnStateChange: 10001 :https://scopus/bugsplat/
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 10010 :https://scopus/bugsplat/
Enabling Quirk StyleSheet
Enabling Quirk StyleSheet
1024[8063d60]: SecureUI:874c288: OnStateChange: 70010 :https://scopus/bugsplat
Document: Done (25.808 secs)
Error loading URL https://scopus/bugsplat
1024[8063d60]: SecureUI:874c288: OnStateChange: 70001
:https://scopus/bugsplat/index.cgi
pushing io layer: ssl
Enabling Quirk StyleSheet
Enabling Quirk StyleSheet
1024[8063d60]: SecureUI:874c288: OnStateChange: 10001
:https://scopus/bugsplat/cookie.js
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 30004
:https://scopus/bugsplat/index.cgi
1024[8063d60]: SecureUI: GetSecurityState:8885f60 - info is 89fa538
1024[8063d60]: SecureUI:874c288: OnStateChange: 10010
:https://scopus/bugsplat/index.cgi
1024[8063d60]: SecureUI: GetSecurityState:8885f60 - info is 89fa538
1024[8063d60]: SecureUI:874c288: OnStateChange: 10004
:https://scopus/bugsplat/cookie.js
1024[8063d60]: SecureUI: GetSecurityState:8acf7b0 - info is 8a18a38
1024[8063d60]: SecureUI:874c288: OnStateChange: 10001
:https://scopus/bugsplat/nslogo.jpg
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 10001
:https://scopus/bugsplat/redbull.jpg
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 10001
:https://scopus/bugsplat/bugchart1.jpg
pushing io layer: ssl
1024[8063d60]: SecureUI:874c288: OnStateChange: 10010
:https://scopus/bugsplat/cookie.js
1024[8063d60]: SecureUI: GetSecurityState:8acf7b0 - no nsIPSMSocketInfo for 0
1024[8063d60]: SecureUI: GetSecurityState:8acf7b0 - no nsIPSMSocketInfo for 0
1024[8063d60]: SecureUI:874c288: OnStateChange - Icon set to broken: 1
1024[8063d60]: SecureUI:874c288: OnStateChange: 10004
:https://scopus/bugsplat/nslogo.jpg
1024[8063d60]: SecureUI:874c288: OnStateChange: 10004
:https://scopus/bugsplat/redbull.jpg
1024[8063d60]: SecureUI:874c288: OnStateChange: 10004
:https://scopus/bugsplat/bugchart1.jpg
1024[8063d60]: SecureUI:874c288: OnStateChange: 10010
:https://scopus/bugsplat/nslogo.jpg
1024[8063d60]: SecureUI:874c288: OnStateChange: 10010
:https://scopus/bugsplat/redbull.jpg
1024[8063d60]: SecureUI:874c288: OnStateChange: 70010
:https://scopus/bugsplat/index.cgi
1024[8063d60]: SecureUI:874c288: Icon set to broken

Comment 1

[John G. Myers]

I have confirmed this also happens with unmodified psm-glue code.  This also 
blocks 41863, so I am nominating it for nsbeta3.

Comment 2

[Brendan Eich [:brendan]]

Cc'ing embedding API pals who may be able to help before rpotts gets back from 
vacation.

/be

Comment 3

[Judson Valeski]

who is removing the security info, and why?

Comment 4

[Doug Turner (:dougt)]

cache?  I thought that we were addrefing these objects.

Comment 5

[John G. Myers]

Further investigation shows that in nsHTTPChannel::GetSecurityInfo(), trans is 
null, mCacheEntry is non-null, and mSecurityInfo is non-null before and null 
after the call to mCacheEntry->GetSecurityInfo().

Comment 6

[John G. Myers]

Attachment: This patch appears to help matters a bit.

Comment 7

[John G. Myers]

Change Summary, was "OnStatusChange() flag_stop notification arriving too late"

Comment 8

[John G. Myers]

Ruslan has is name on the HTTP channel code that attempts to save security info 
before the transport disappears.  Reassigning to him.

Comment 9

[Gagan]

approving. someone still needs to review. 

Comment 10

[ruslan]

Gagan, can I put you as r/a?

Comment 11

[ruslan]

The patch is in

Comment 12

[Tom Everingham]

verified:
Linux 2000090708