Closed Bug 453372 Opened 12 years ago Closed 12 years ago
Import NSPR 4
.7 .2 Beta 3 into mozilla-central .
I'd like to import NSPR_4_7_2_BETA3 into mozilla-central. This brings in the following bug fixes: bug 451476 bug 432430 (partial)
Benjamin had suggested, when landing updates of NSPR or NSS into mozilla-central, we should a bug and patch and a review. But I think the way we are doing it here (and earlier in bug 450696) is too much work. Please let's find a simpler mechanism. It's duplicate work. All changes have already been reviewed. It's difficult to review big patches and conclude they are really identical to the intention. I propose we don't require a review of this patch. Using Wan-Teh's intention in this bug as an example, I propose the following: - Wan-Teh files a bug with the same subject as he did - Wan-Teh writes down a cvs diff command that can be used to produce the difference between currently-contained and desired-new, for example: cvs rdiff -u NSPR_4_7_2_BETA2 -u NSPR_4_7_2_BETA3 - Wan-Teh writes down the essential text command he intends to use for importing, for example: python client.py update_nspr NSPR_4_7_2_BETA3 - Don't use a patch, just write the above into a comment. - Kai writes "r=kaie for the propose action from comment 1" in a comment - Wan-Teh goes ahead and imports
I assume Wan-Teh intends to do what I describe in comment 1. r=kaie for that update
I committed the changeset abe32503a125 and pushed it to mozilla-central. $ hg push pushing to ssh://hg.mozilla.org/mozilla-central/ searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 11 changes to 11 files
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.