453453 - Error in calAttendee.js when opening properties dialog

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

On calendars that don't have organizerId set, an error shows up, resulting in an empty properties dialog. This patch fixes.

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 336651 [details] [diff] [review]
Fix - v1

r=dbo

Comment 3

[Decathlon]

Patch fixes the properties dialog problem, but now, when I create a new local calendar, I can't see the email drop-down list in the second step of the wizard (neither the label).
Not sure if related to this bug or another one.
Like this one, it worked on Lg 2008090118.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Thanks for testing! This saved me a further checkin and some time ;-)


This should fix it, after talking with daniel we decided to get rid of the label, since the imip identity and the organizer id are really two different things. Nevertheless we decided to provide a way to hide the menulist.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2 (no whitespaces)

I've changed a bunch of whitespaces in the previous patch, here a version without whitespace changes.

Comment 6

[Daniel Boelzle [:dbo]]

Comment on attachment 336831 [details] [diff] [review]
Fix - v2

r=dbo

Please document that imip.identity.disabled is transient (maybe take over into the transient list in base provider) to indicate that the property is a static thing of the provider.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #6)
> Please document that imip.identity.disabled is transient (maybe take over into
> the transient list in base provider) to indicate that the property is a static
> thing of the provider.
Done.

Checked in on HEAD and MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH

-> FIXED

Comment 8

[Andreas Treumann]

Checked in lightning 2008090503 -> VERIFIED.