Closed
Bug 45353
Opened 24 years ago
Closed 23 years ago
nsXULAttribute::gFreeList is leaked
Categories
(Core :: XUL, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: waterson, Assigned: waterson)
References
()
Details
(Keywords: helpwanted, memory-footprint, memory-leak)
Attachments
(1 file)
4.57 KB,
patch
|
shaver
:
review+
|
Details | Diff | Splinter Review |
The nsXULAttribute class keeps a free-list of nsXULAttribute objects, since these are created and destroyed frequently. The free-list itself is never released.
Assignee | ||
Updated•24 years ago
|
Assignee | ||
Comment 1•24 years ago
|
||
This is a big leak, but it's a one-time thing. jud: I'm marking this as Future, but we can pull it back if you think it's an issue for embedding.
Keywords: nsbeta3 → helpwanted
Target Milestone: M18 → Future
Comment 2•24 years ago
|
||
sounds a lot like the recycler problem rick isolated in the parser. The "leak" will be cleaned up on shutdown eventually, so the problem here is that we have this "cache" accumulating so much. I'm cc'ing dougt who's looking at memory pressure callbacks. this is probably a candidate.
Assignee | ||
Comment 4•23 years ago
|
||
This was relevant back in the day when we were trying to squeeze every last ounce of performance out of the XUL content model for the mailnews threadpane. Now, the footprint savings is probably far more important. (Plus, we're doing tons of stuff to get rid of attribute copies, so there ought to be fewer nsXULAttribute objects anyway.)
Why would this be a footprint gain?
Assignee | ||
Comment 6•23 years ago
|
||
Because we never shrink or reclaim the arenas from which nsXULAttribute objects are allocated. See bug 109344, e.g.
*** Bug 109344 has been marked as a duplicate of this bug. ***
Comment 8•23 years ago
|
||
Comment on attachment 57264 [details] [diff] [review] remove one-off allocator for nsXULAttribute objects r=shaver. (And a code-size win, to boot!)
Attachment #57264 -
Flags: review+
Assignee | ||
Comment 9•23 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•