453562 - full page zoom effects on page sized ignored by OS X green zoom button logic

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: General, defect)

Description

[Ilya Sherman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.3pre) Gecko/2008083000 Camino/2.0a1pre (like Firefox/3.0.3pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.3pre) Gecko/2008083000 Camino/2.0a1pre (like Firefox/3.0.3pre)

When full-page zoom is used, a page's dimensions can sometimes change from the original dimensions (especially if you zoom in on the page, the width can increase).  However, pressing the green orb at the top-left of the window seems to use the original page dimensions rather than the zoomed dimensions to calculate the optimal window size.  This often means that when I want a window I've zoomed in on to get slightly larger, it instead gets much smaller.

Reproducible: Always

Steps to Reproduce:
1. Load a page (like this one) in a relatively small window, but large enough to lack a horizontal scroll bar.
2. Use full-page zoom to zoom in until you get a horizontal scroll bar.
3. Click the green "zoom" orb to resize the window.
Actual Results:  
The window width remains the same or shrinks

Expected Results:  
The window width grows

Comment 1

[philippe (part-time)]

I wonder if there is an underlying core issue here.
(ofcourse, I can't test that, as the 'fox doesn't do the window-zoom thingie the same way as Camino).

Comment 2

[philippe (part-time)]

Attachment: test case

The container will grow when zoomed, with page-zoom _and_ text-zoom.
With text-zoom, the window grows when using the window control, with page-zoom it doesn't.

With page-zoom, the window toggles between initial size and ~1000px (@default font-size, 16px), even after zooming in.

Comment 3

[Stuart Morgan]

We'll have to see what (if anything) the intrinsic size APIs say about device vs CSS pixels now that they aren't necessarily the same.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

hendy looked into this (I think) and commented in bug 360765; my guess is we'll minus this.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since it looks like this depends on doing fixing mentioned in bug 360765 comment 4 and said bug is not a 2.0 bug anymore, minusing this one, too.

Comment 6

[Jeremy Clarke]

It seems to me that in OSX 10.6 Snow Leopard the inherent behavior of Green Orb has changed. It now is a much more useful and simple function: If not fullscreen, make window fullscreen, if already fullscreen, revert window to previous state. This is much more like Windows behavior and it makes it much easier to predict what will happen. 

Given this change in OSX it seems that this bug is no longer relevant, as tuning Firefox to suit the pickiness of the old green orb behavior is now unnecessary.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

1) This is a Camino bug, not a Firefox bug.

2) The HIG have not changed in their specification of how the zoom button functions: http://developer.apple.com/mac/library/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGWindows/XHIGWindows.html#//apple_ref/doc/uid/20000961-BACEDHFG (specifically: "The zoom button should not cause the window to fill the entire screen unless that was the last state the user set.")