Closed Bug 453763 Opened 14 years ago Closed 14 years ago

nsIMsgFolderNotificationService needs a folderAdded notification

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: asuth, Assigned: rain1)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 439225 revamped nsIMsgFolderNotificationService.  It was still desired to provide a folderAdded notification, which is being spun off to this bug.

STEEL uses nsIMsgFolderNotificationService for its notifications and wants (actually, currently thinks) it can get these from the (old version of the) interface.  Marking this as blocking STEEL 0.1 (bug 408370).
Flags: blocking-thunderbird3.0b1?
(In reply to comment #0)
> STEEL uses nsIMsgFolderNotificationService for its notifications and wants
> (actually, currently thinks) it can get these from the (old version of the)
> interface.

Yes, that sounds right -- it didn't actually get the notifications.

I'm not assigning this to myself right now, as there are a couple of other things in my way, but I think I'll look into this if no one else gets to it first.
STEEL isn't targeted for b1 at this stage, so this bug doesn't need to either. But doing it early would of course be fine.
Flags: blocking-thunderbird3.0b1?
Flags: blocking-thunderbird3.0b1-
Flags: blocking-thunderbird3+
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
moving to b2
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
sid0, can you take this one now?
Yes.
Assignee: nobody → sid1337
Status: NEW → ASSIGNED
The patch includes
- additions to the interfaces, including a new flag
- backend code to support this
- tests for local folders
- temporarily disable the notification for consumers -- they can re-enable it as they see fit.

I had to break up CreateSubfolder, as it was called on copy, too. This also gave me the opportunity to add an extra parameter and clean up some of the code there. Suggestions for better names?

Asking for r/sr=bienvenu, r=asuth for gloda changes (more like testing to see if this works for him ;) ) and r=Standard8 for test changes.
Attachment #352778 - Flags: superreview?(bienvenu)
Attachment #352778 - Flags: review?(bienvenu)
Attachment #352778 - Flags: review?(bugmail)
Comment on attachment 352778 [details] [diff] [review]
folderAdded notification + changes to consumers + tests for local folders

Gah, sorry, a couple of dump statements crept in -- I've removed them locally.
Attachment #352778 - Flags: review?(bugzilla)
Comment on attachment 352778 [details] [diff] [review]
folderAdded notification + changes to consumers + tests for local folders

r=me for the unit test changes.
Attachment #352778 - Flags: review?(bugzilla) → review+
Attachment #352778 - Flags: superreview?(bienvenu)
Attachment #352778 - Flags: superreview+
Attachment #352778 - Flags: review?(bienvenu)
Attachment #352778 - Flags: review+
As this has sufficient reviews to get checked in and there are a couple of patches held up because of this, I'll cancel asuth's review for the moment.
Attachment #352778 - Attachment is obsolete: true
Attachment #354226 - Flags: superreview+
Attachment #354226 - Flags: review+
Attachment #352778 - Flags: review?(bugmail)
Keywords: checkin-needed
Blocks: 470850
Attachment #354226 - Attachment description: updated patch, without the dump statements → updated patch, without the dump statements [Checkin: Comment 10]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.