453792 - Bugzilla should differentiate in headers (X-Bugzilla-Type) between new and changed mail

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Gervase Markham [:gerv]]

People would like to filter email based on whether it's the notification of a new bug or whether it's an update on an existing one. Yes, you can parse the Subject line for "] New:", but that would break for localizations and there's an (OK, small) risk of false positives.

Currently: 
X-Bugzilla-Type: newchanged

Suggested:
X-Bugzilla-Type: new
or
X-Bugzilla-Type: changed

This is a one-line change to newchangedmail.txt.tmpl.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

The obvious patch.

Gerv

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 337008 [details] [diff] [review]
Patch v.1

r=Wurblzap by inspection. This will break existing filters triggered by "newchanged", so it may need to be relnoted.

Comment 3

[Gervase Markham [:gerv]]

Dave, Max,

I did this for bz. Can we get it on b.m.o. too?

Gerv

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> I did this for bz. Can we get it on b.m.o. too?

Can you get it committed to Bugzilla 3.2 branch? Much easier just to pull from upstream rather than taking a local bmo-only patch.

Comment 5

[Gervase Markham [:gerv]]

OK, I'll try. Let's see what happens when I set this flag...

Gerv

Comment 6

[Max Kanat-Alexander]

Unfortunately, those headers represent a sort of "API" and I can't change them on the branch this close to a release.

Comment 7

[Gervase Markham [:gerv]]

Surely before a major release (as opposed to after) is the right time to change an API?

I still want this for b.m.o., though.

Gerv

Comment 8

[Frédéric Buclin]

But we already released RC1.

Comment 9

[Gervase Markham [:gerv]]

Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.12; previous revision: 1.11
done

Gerv

Comment 10

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.