453896 - need to flush delayed resizes during layout flushes

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I initially wrote this patch thinking it might fix bug 448132, but it didn't.

However, after working on bug 453759, I realized that this patch fixes a bug where a bunch of the tests in layout/style/test/test_media_queries.html fail when the test is loaded in a non-active tab, i.e., one of the following two ways:

Steps to reproduce:
 1. cd objdir/_tests/testing/mochitest && python ./runtests.py --test-path=layout/style
 2. right click on the "test_media_queries.html" link and select "Open in new Tab"
 3. switch to the new tab
 4. hit reload
 5. switch back to the directory listing tab
 6. right click on the test page tab and select "Reload Tab"
 7. switch to the test page tab

Actual results:
 3. a bunch of the tests fail (this is way-to-reproduce #1)
 5. all tests pass
 7. a bunch of the tests fail again (this is way-to-reproduce #2)

Expected results:
 3. all tests pass
 5. all tests pass
 7. all tests pass

The attached patch fixes the bug, but I need to write a test that tests it.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, 3/5/7 lists in the above comment should be 3/4/7 in both cases.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch with tests

This adds two tests:
 * a normal mochitest that runs a part of test_media_queries.html inside an iframe in the non-visible part of a deck
 * a browser mochitest that runs the same part of test_media_queries.html in a new tab

I verified that the tests pass with the patch and that 6 of the tests fail if I comment out the FlushDelayedResize call (added in this patch) in nsPresShell.cpp

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(It also wouldn't surprise me if this patch fixed some real-world bugs...)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 337497 [details] [diff] [review]
patch with tests

Please rev nsIViewManager's IID, and looks good.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed: http://hg.mozilla.org/mozilla-central/rev/250798f99819

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

Possibly caused https://bugzilla.mozilla.org/show_bug.cgi?id=454578 ??

Comment 7

[Aakash Desai [:aakashd]]

pushed: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c9482d51ef47


Seeing as there hasn't been any discussions about this bug for 8 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.

Comment 8

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf53cbc6ddef

Comment 9

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c9ed9894456

Comment 10

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7be0e82e845

Comment 11

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=902fb4a0cee4

Comment 12

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f2a80f03c34