454025 - Extension functions fail because libgkplugin.so does not get installed

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Connor Behan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072612 GranParadiso/3.0.1
Build Identifier: trunk

It looks like libgkplugin.so was deliberately omitted from "make install" but this should not be the case. The extensions dialog fails to render, extensions fail to install and the error console gives an error for not recognizing "Components.classes" at line 844 of extensions.js. These go away when libgkplugin.so is installed. Omitting gkplugin.dll on Windows may or may not cause the same problems, I haven't tested that.

Reproducible: Always

Steps to Reproduce:
1.Build thunderbird from comm-central and install it with make install
2.Go to Addons or Error Console to notice a bunch of extension related errors
3.
Actual Results:  
Components.classes was not found in extensions.js:844 and extensions failed to install or show up in the Addons dialog.

Expected Results:  
Installing and querying extensions should have worked and exensions.js should not have had issues.

Comment 1

[Connor Behan]

Attachment: Tentative fix

Comment 2

[David :Bienvenu]

it's odd that we have both libgkplugin.so and gkplugin.dll - cc'ing Mark in case he has any insight...

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> it's odd that we have both libgkplugin.so and gkplugin.dll - cc'ing Mark in
> case he has any insight...

I've done some investigation and found in cvs the following comment by Scott for when those files were added to the removed files list:

"fix some crashers because we don't support plugins by default"

No bug referenced though.

After a bit more thought, I'm guessing Connor has tried this on a non-static build - an investigation of my mac builds, reveals that only non-static builds have a separate libgkplugin.dylib (the mac equivalent).

So for static builds, we've actually been including it for ever, and this explains why it isn't in our windows packages file.

Therefore I think there's no point in *gkplugin* being listed in the NO_PKG_FILES section of our mail/installer/Makefile.in as its just confusing, and doesn't benefit us in any way.

Comment 4

[Connor Behan]

Attachment: Fix

Removes both gkplugin files.

Comment 5

[Mark Banner (:standard8)]

Connor, just for my confidence, please could you confirm if you were trying make install on a non-static build?

Comment 6

[Connor Behan]

Yes. To even run make install on a non-static build I had to change other parts (bug 453920) but that's better than a static build on my system. For some reason static builds of mozilla programs always segfault for me... no idea why.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 337338 [details] [diff] [review]
Fix

ok, I'm willing to take this. r=me, I'll check this in in a moment.

Comment 8

[Mark Banner (:standard8)]

Checked in, changeset id: 293:4a8d961d55d0