Deprecate the ini creation macros from common.nsh

RESOLVED FIXED in mozilla1.9.1b1

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla1.9.1b1
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

These provide little value for the individual applications and at times create build warning when Firefox adds new functionality to these. I will leave these macros in common.nsh marked a deprecated until all consumers no longer use them and copy the code that Firefox uses over to its unstaller.nsi / uninstaller.nsi.

SeaMonkey should copy the appropriate macros when it is updated to use the new code as was done for Thunderbird.

Not sure if McCoy has landed its installer code... either way the macros it uses should just be copied over.

I'll take care of Firefox in this bug and mark the macros as deprecated.

I'll file a new bug for Thunderbird and take care of the changes needed for it in the new bug.
Created attachment 337386 [details] [diff] [review]
Toolkit and Firefox patch rev1
Assignee: nobody → robert.bugzilla
Attachment #337386 - Flags: review?(jmathies)
Filed bug 454133 for Thunderbird... it isn't dependent since there is nothing in this bug the copying of the code depends on.

Updated

10 years ago
Attachment #337386 - Flags: review?(jmathies) → review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c83952b7df09c4df2c0652adf4c5f2841d491b3c
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.