Closed Bug 454182 Opened 13 years ago Closed 13 years ago

Forward as attachment from open eml file broken after fix to bug 366482

Categories

(MailNews Core :: Composition, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Keywords: regression)

Attachments

(1 file)

Now the fix to bug 366482 has gone in, trying to forward as an attachment from eml file that has been opened is broken - subject field is greyed out as is the address field.
Steps to reproduce
1/ Open an email that has been forward as an attachment
2 [review]/ Try to forward that email

Expected result
1/ Subject contains subject from forwarded email
2/ Address fields can be typed into

Actual result
1/ Subject field is blank and disabled
2/ Address fields are blank and disabled

The following line in both (mail and mailnews) mailCommands.js
msgComposeService.OpenComposeWindow(null, null, uri, type, format, identity, msgWindow);
needs to be changed to:
msgComposeService.OpenComposeWindow(null, hdr, uri, type, format, identity, msgWindow);
This patch:
* Replaces one the null arguments with hdr so that compose window is no longer broken.
* Adds check of uri to SeaMonkey (which TB already does).
Attachment #337452 - Flags: superreview?(bienvenu)
Attachment #337452 - Flags: review?(mnyromyr)
Attachment #337452 - Flags: review?(mnyromyr) → review+
Comment on attachment 337452 [details] [diff] [review]
mailCommands.js patch v0.1 (Checkin: Comment 6)

Looks good.
Comment on attachment 337452 [details] [diff] [review]
mailCommands.js patch v0.1 (Checkin: Comment 6)

thx, Ian
Attachment #337452 - Flags: superreview?(bienvenu) → superreview+
Requesting a= for SM2.0a1
approval-seamonkey2.0a1+ as this looks really low-risk, high-reward :)
Comment on attachment 337452 [details] [diff] [review]
mailCommands.js patch v0.1 (Checkin: Comment 6)

http://hg.mozilla.org/comm-central/rev/572833185ccf
Attachment #337452 - Attachment description: mailCommands.js patch v0.1 → mailCommands.js patch v0.1 (Checkin: Comment 6)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
Depends on: 456668
You need to log in before you can comment on or make changes to this bug.