454182 - Forward as attachment from open eml file broken after fix to bug 366482

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Ian Neal]

Now the fix to bug 366482 has gone in, trying to forward as an attachment from eml file that has been opened is broken - subject field is greyed out as is the address field.
Steps to reproduce
1/ Open an email that has been forward as an attachment
2 [review]/ Try to forward that email

Expected result
1/ Subject contains subject from forwarded email
2/ Address fields can be typed into

Actual result
1/ Subject field is blank and disabled
2/ Address fields are blank and disabled

The following line in both (mail and mailnews) mailCommands.js
msgComposeService.OpenComposeWindow(null, null, uri, type, format, identity, msgWindow);
needs to be changed to:
msgComposeService.OpenComposeWindow(null, hdr, uri, type, format, identity, msgWindow);

Comment 1

[Ian Neal]

Attachment: mailCommands.js patch v0.1 (Checkin: Comment 6)

This patch:
* Replaces one the null arguments with hdr so that compose window is no longer broken.
* Adds check of uri to SeaMonkey (which TB already does).

Comment 2

[Karsten Düsterloh]

Comment on attachment 337452 [details] [diff] [review]
mailCommands.js patch v0.1 (Checkin: Comment 6)

Looks good.

Comment 3

[David :Bienvenu]

Comment on attachment 337452 [details] [diff] [review]
mailCommands.js patch v0.1 (Checkin: Comment 6)

thx, Ian

Comment 4

[Ian Neal]

Requesting a= for SM2.0a1

Comment 5

[Robert Kaiser]

approval-seamonkey2.0a1+ as this looks really low-risk, high-reward :)

Comment 6

[Ian Neal]

Comment on attachment 337452 [details] [diff] [review]
mailCommands.js patch v0.1 (Checkin: Comment 6)

http://hg.mozilla.org/comm-central/rev/572833185ccf