454485 - Clean up unused variables in places

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: patch

Vars only used in debug builds are wrapped in #ifdefs
Who is the right peer for review here?

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 337757 [details] [diff] [review]
patch

Ugh - not sure I like the look of that new code.  Also, I think we might want to treat those a bit more fatally...

dietrich can decide though

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 337757 [details] [diff] [review]
patch

Thanks for thinking about this Arpad. However, this pattern is persistent throughout the Mozilla codebase, and your approach makes the code very difficult to read. I think a better approach would be a more comprehensive one, that addresses this issue throughout the codebase, via a preprocessor of some kind, that removes these for release builds at compile-time.

Comment 3

[Dietrich Ayala (:dietrich)]

WONTFIXing this. if you're interested in a broader approach, please file a new bug.

(In reply to comment #1)
> Also, I think we might want
> to treat those a bit more fatally...

Agreed, for some of those, clearly corruption or other mangling has happened, and we should bubble up to a backup+recovery scenario.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv