454709 - WinCE Resource Compiling Needs Shunt Application

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Patch to add arm-wince-res.c source to VS8 and VS9 WinCE tools

In order to compile resources within the SECURITY module, several pathnames have to be converted from MingW32 to Windows (i.e., "/c/...." to "c:/....")

This means we need a resource compiler shunt tool (arm-wince-res.exe) to do the command line conversion as well as calling the correct SDK resource compiler.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 337997 [details] [diff] [review]
Patch to add arm-wince-res.c source to VS8 and VS9 WinCE tools

this looks fine, but the patch to wince/tools/Makefile didn't apply.  is there some other patch needed?

Comment 2

[John Wolfe (:wolfe)]

Good observation - this patch depends upon bug 444485 - Make WinMobile Build work with Visual Studio 2008 (VS9).  

Seems that every bug I added with a depends upon field filled in was actually added to bugzilla with the depends upon field blanked out.  Sorry for the confusion - and this attachment should apply cleanly once 444485's attachment is applied.

Comment 3

[John Wolfe (:wolfe)]

Comment on attachment 337997 [details] [diff] [review]
Patch to add arm-wince-res.c source to VS8 and VS9 WinCE tools

This patch applies for me, as long as I apply the patch for bug 444485 first.

444485 is the bug for including support for Visual Studio 9, and this bug patch depends upon that previously-added VS9 support.

I had originally added a "depends upon" 444485 when creating this bug, but somehow that field got lost.  Reset "depends upon" field inside the associated bug, and now this patch can be re-tried.

I am sorry that I made extra work for you, doug!

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 337997 [details] [diff] [review]
Patch to add arm-wince-res.c source to VS8 and VS9 WinCE tools

ted is already reviewing a bunch of this stuff.

It looks okay to me;  assuming things keep building.

why a specific target for building the res tool?

Comment 5

[Doug Turner (:dougt)]

the res tool is needed because the path names have to be modified to convert ming to something that the vs tools understand.

Comment 6

[Doug Turner (:dougt)]

changeset:   19522:e0b2a01975da
tag:         tip
user:        Doug Turner <[e-mail]>
date:        Mon Sep 22 22:08:46 2008 +0100
summary:     Bug 454709 - WinCE Resource Compiling Needs Shunt Application.  patch by wolfe. r=dougt. npodb