454546 - Update EM and blocklist service to be initialised on profile-after-change

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Currently both services initialise at app-startup just so they can register a few notifications then do all their processing at profile-after-change anyway. Might as well simplify that now bug 452486 is fixed

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple patch to do this. The profile-after-change category doesn't support the service flag, it just always gets components as services.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 345942 [details] [diff] [review]
patch rev 1

Dave, with this change can't the adding of the quit-application observer, etc. also be removed?

  observe: function EM_observe(subject, topic, data) {
    switch (topic) {
    case "profile-after-change":
      gOS.addObserver(this, "quit-application", false);
      this._profileSelected();
      break;
    case "quit-application-requested":
      this._confirmCancelDownloadsOnQuit(subject);
      break;
    case "offline-requested":
      this._confirmCancelDownloadsOnOffline(subject);
      break;
    case "quit-application":
      gOS.removeObserver(this, "quit-application");
      break;
    case "xpcom-shutdown":
      this._shutdown();
      break;
    case "nsPref:changed":
      if (data == PREF_EM_LOGGING_ENABLED)
        this._loggingToggled();
      else if (data == PREF_EM_CHECK_COMPATIBILITY ||
               data == PREF_EM_CHECK_UPDATE_SECURITY)
        this._updateAppDisabledState();
      else if ((data == PREF_MATCH_OS_LOCALE) || (data == PREF_SELECTED_LOCALE))
        this._updateLocale();
      break;
    }
  },

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 2

Yeah hadn't spotted that, done the same with the blocklist service too.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 346020 [details] [diff] [review]
patch rev 2

This is a trivial fix that slightly reduces calls into the extension manager and blocklist service during startup. Not likely to see a perf win as it is so small but would like to land it anyway.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346020 [details] [diff] [review]
patch rev 2

a191=beltzner

Comment 6

[Dave Townsend [:mossop]]

Attachment: patch for checkin

Comment 7

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/169f2cc23290

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Dave, plans to land this on 191?

Comment 9

[Tony Chung [:tchung]]

Not much i can verify here.  code cleanup work.  Marking Verified per checkin.