Closed
Bug 454562
Opened 16 years ago
Closed 15 years ago
clean up onEnterPrintPreview, onExitPrintPreview and related code
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 2 obsolete files)
|
11.08 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #337855 -
Flags: review?(mano)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 337855 [details] [diff] [review]
patch
I don't like the idea of scoping function which cannot use |this| reliably when they are cayou want to scope these functions, add an API to print preview to which know about onEnter, onExit etc. and then pass over the listener.
Attachment #337855 -
Flags: review?(mano) → review-
|
Assignee | |
Comment 2•16 years ago
|
||
No code in mozilla-central or comm-central passes a window to the printPreview method, so I removed aWindow.
Attachment #337855 -
Attachment is obsolete: true
Attachment #340340 -
Flags: review?(mano)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #340340 -
Attachment is obsolete: true
Attachment #344779 -
Flags: review?(mano)
Attachment #340340 -
Flags: review?(mano)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 344779 [details] [diff] [review]
updated to trunk
r=mano.
Please file a bug on SM and TB if there's anything they need to update in their files.
Attachment #344779 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
You need to log in
before you can comment on or make changes to this bug.
Description
•