515420 - Extension smooth scrolling has quit working

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Ria Klaassen (not reading all bugmail)]

This extension has suddenly stopped working in trunk builds:
http://www.aa.alpha-net.ne.jp/kataho/xpi/yass.html

Regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7e22b8a3560f&tochange=ed9f990c6fcc

YASS is a popular and important extension and I don't know if this is something that should be fixed in Firefox or in YASS.

Comment 1

[Ria Klaassen (not reading all bugmail)]

And under some, yet unknown conditions it suddenly starts working again, I don't know for how long.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Closing a tab seems to cure it.

Comment 3

[Dão Gottwald [:dao]]

Have you verified that bug 514310 caused this, and that it's a bug in our code?

Comment 4

[Ria Klaassen (not reading all bugmail)]

The range of comment 0 has been verified. One of the two bugs has caused the issue, or has made the defect clear.

Comment 5

[Dão Gottwald [:dao]]

Is there anything in the error console?

Comment 6

[Ria Klaassen (not reading all bugmail)]

Error: onEnterPrintPreview is not defined
Source File: chrome://yass/content/main.js
Line: 542

Comment 7

[Dão Gottwald [:dao]]

onEnterPrintPreview doesn't exist anymore, so the extension would need an update.

Mano, do you think we should add function onEnterPrintPreview() { PrintPreviewListener.onEnter(); } for backward compatibility?

Comment 8

[Andy McKay]

Legacy extensions are no longer valid in Firefox 57, closing.