454679 - MozillaStageUpload should be able to upload language packs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

To be able to use MozillaStageUpload for L10n builds, it should have an option for uploading langpacks. Patch upcoming.

Comment 1

[Robert Kaiser]

CCing gozer, as in addition to the just-checked-in bug 453135, this is the other part we want to use in L10n builder configs.

Comment 2

[Robert Kaiser]

Attachment: add an option for uploading langpacks

This patch adds this option, defaulting it to off so that we don't return with a failure on finding the pattern on non-L10n builders.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 337972 [details] [diff] [review]
add an option for uploading langpacks

>Index: steps/transfer.py
...
>+        @type  uploadLangPacks: bool
>+        @param uploadLangPacks: When True, the MozillaStageUpload will upload
>+                                language pack XPIs to the datedDir/latestDir.
>+                                This option only applies when releaseToDated or
>+                                releaseToLatest is True.

Please add a 'Default: False' at the end of this doc. For kicks, you could put a 'Default=True' on uploadCompleteMar. r+ with that.

Comment 4

[Robert Kaiser]

Checked in with both the defaults for uploadCompleteMar and uploadLangPacks noted in the docs, thanks for the fast review!