454964 - |make check|: test_0110_general.js reports leak 1

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

spinoff of Bug 449240 for app update

Comment 1

[Robert Strong (they/them - no direct email)]

Per Bug 449240 comment #4 these two tests
have the same report with only 1 XPCWrappedNative and 1 XPCWrappedNativeProto
more.

Comment 2

[Robert Strong (they/them - no direct email)]

It appears that this._update is leaked on the following line

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#2350

Comment 3

[Peter Van der Beken [:peterv]]

You could try to remove _update and other properties holding XPCOM objects from the prototypes and instead declare them in the component's constructor (add |this._update = null| in |Downloader(background))|. Putting them on the prototype keeps them alive until we unload the module, which is after the last cycle collection.

Comment 4

[Robert Strong (they/them - no direct email)]

The patch in bug 324121 fixes the leak in test_0030_general.js

Comment 5

[Robert Strong (they/them - no direct email)]

test_0030_general.js no longer leaks after the checkin of bug 324121. Updating summary accordingly.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: simple patch - rev1

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

(In reply to comment #5)
> test_0030_general.js no longer leaks after the checkin of bug 324121.

I confirm that this test doesn't leak (at all) anymore.

(In reply to comment #6)
> simple patch - rev1

I confirm that this patch fixes this test (whole) leak.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 346549 [details] [diff] [review]
simple patch - rev1

"approval1.9.1b2=?":
Trivial leak fix, no risk.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346549 [details] [diff] [review]
simple patch - rev1

a=beltzner

Comment 10

[Dave Townsend [:mossop]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/301a7a8617e6

Comment 11

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

V.Fixed