Closed Bug 455001 Opened 16 years ago Closed 14 years ago

Remove dependency on tasksOverlay.js from pref-smartupdate.xul

Categories

(SeaMonkey :: Preferences, enhancement)

Product:
SeaMonkey
Component:
Preferences
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: philip.chee, Unassigned)

References

(Blocks 1 open bug)

Details

As far as I can see the only reason tasksOverlay.js is included is to use toEM() which is a tad overkill. The prefwindow binding has a method openWindow(aWindowType, aURL, aFeatures, aParams) which can be used instead.

In pref-certs.js and pref-validation.js document.documentElement.openWindow() is used. We could simplify this by adding:

window.toOpenWindowByType = document.documentElement.openWindow;

to preferences.js or perhaps in the prefwindow.xml constructor.
Setting dependency since one or the other should be fixed but not both.
Depends on: 458512
Since bug 458512 is fixed I guess this is WONTFIX.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.