455104 - UI for setting delete model is gone

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Phil Ringnalda (:philor)]

STR:

1. Open Account Settings, select an IMAP server, select Server Settings

The whole IMAP delete model radiogroup (in the Server Settings group, following the label "When I delete a message:") will be missing, and the console says

Error: [Exception... "Not enough arguments [nsIMsgFolder.createSubfolder]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/folderLookupService.js :: fls_getFolderById :: line 73"  data: no]
Source File: file:///Applications/Thunderbird.app/Contents/MacOS/components/folderLookupService.js
Line: 73

Comment 1

[Phil Ringnalda (:philor)]

Actually, since I can change other settings on that page and have them stick in a build from 2008-09-04, and can't in a build from today, I probably meant "breaks setting anything on the Server Settings pane for an IMAP server"

Comment 2

[Joey Minta]

This just needs a null msgWindow argument appended to the end of the call, but I won't be in a position to draft a patch until Tuesday-ish.

Comment 3

[Phil Ringnalda (:philor)]

Well, yeah, it needs that, but the problem is that we're getting into the createSubFolder part, because we're looking for imap://[e-mail]/Trash when what's in this._map is imap://[e-mail]/INBOX/Trash - apparently setupImapDeleteUI() expects GetMsgFolderFromUri(aServerId) to include the /INBOX/ part, and it now doesn't.

Comment 5

[Mark Banner (:standard8)]

For the record, bug 441437 has been backed out, but this bug is still present.

Comment 6

[Mark Banner (:standard8)]

So it seems there were two problems here. One was bug 441437 (as referenced early on), the other bug 422814 regressed.

Bug 455069 has fixed this bug (checked on local build) will be in tomorrow's nightlies.