455430 - Add an X-Bugzilla-URL header to identify what install this email comes from

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Max Kanat-Alexander]

Right now, when you have multiple installations on the same machine that all send with the same "From" (like we have on landfill), you can't tell very easily what installation emails come from (without checking the Message-ID and In-Reply-To header both, and that might not work for all emails).

We should have an X-Bugzilla-URL header that contains the full urlbase for the Bugzilla installation.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

I remove the "https?://" from the front, because some of these emails can be sent when the user isn't logged in, and then correct_urlbase() isn't always going to return the same thing, and we want this to always be exactly the same so that you can filter *all* emails on it.

Comment 2

[Max Kanat-Alexander]

Oh, hmm, maybe we should just add it inside of Bugzilla::Mailer? That way we'd only have to do it in one place. That seems easiest.

Comment 3

[A. Shimono [:himorin]]

As some sites' admin, I'd prefer to be able to fully customize bug mail header.
Some site might hope to add such header not by X-Bugzilla-URL but List-Id or something.

Comment 4

[Max Kanat-Alexander]

Attachment: v2

This does it in Bugzilla::Mailer--much more reliable.

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 338775 [details] [diff] [review]
v2

r=bbaetz. This is for filtering not viewing, so even if the http URL isn't reachable it doesn't really matter

Comment 6

[Max Kanat-Alexander]

(In reply to comment #3)
> As some sites' admin, I'd prefer to be able to fully customize bug mail header.
> Some site might hope to add such header not by X-Bugzilla-URL but List-Id or
> something.

  As the author of the Bugzilla supybot plugin, I'd really prefer that all installations use the same header. :-)

  However, if you wanted to customize this, you could still do it by editing the code here.

Comment 7

[Max Kanat-Alexander]

Checking in Bugzilla/Mailer.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Mailer.pm,v  <--  Mailer.pm
new revision: 1.22; previous revision: 1.21
done

Comment 8

[A. Shimono [:himorin]]

(In reply to comment #6)
> > As some sites' admin, I'd prefer to be able to fully customize bug mail header.
> > Some site might hope to add such header not by X-Bugzilla-URL but List-Id or
> > something.
> 
>   As the author of the Bugzilla supybot plugin, I'd really prefer that all
> installations use the same header. :-)

On that point, it should be at Bugzilla::Mailer. :-)

Comment 9

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.