455436 - XPConnect insists on using its own error reporter even when another is already set

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This means that I can't guarantee errors are always propagated correctly from a worker to its parent. I got around this by calling my message handlers manually in the threads code but I can't do something similar for XHR. Patch attached.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch v1.1

Oops, fixed XPConnect style problems.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Additional changes

Need to fix xpcshell's error handler so that unit tests succeed...

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Fix DOM error reporter

Bah, gotta fix the DOM error reporter to ignore inner frame exceptions also, otherwise mochitests fail all over the place :(

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.2

This is a rollup of all previous patches.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed changeset 3aec0eec68a1 to mozilla-central.

Comment 6

[Boris Zbarsky [:bzbarsky]]

This broke reporting of JS errors in event handlers.  See bug 489671.