455474 - cleanup nsNavBookmarks::init

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

Attachment: patch

we are doing that migration in nsNavBookmarks::init, since the code was added after migrateV6up we can move it to migrateV7up

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

well init needs a cleanup, so morphing bug

this actually act more as a reminder, waiting for fsync stuff before producing a final patch and asking review.

some note:
at the start we are reading mRoot as the item in bookmarks table that has parent = 0, but then we are overwriting it in createRoots, so unless there is any reason to have root before initRoots, we don't need it

some function is not checked for success

we should move statements in their own function, so init will be cleaner

pass the known connection to init functions when possible

and do migration code move (see first patch)

Comment 2

[Marco Bonardo [:mak]]

Attachment: fsync unbitrotted

unbitrot for fsync stuff, previous cleanup plus define a global mDBConn instead of always asking history instance and getting the connection through DBConn().

Comment 3

[Marco Bonardo [:mak]]

Attachment: better

previous one was wrong patch version

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 342918 [details] [diff] [review]
better

other ts patches are based on this

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 342918 [details] [diff] [review]
better

the bundle service is only used in InitDefaults, so could be moved there, so no longer in the normal startup path.

Comment 6

[Marco Bonardo [:mak]]

(In reply to comment #5)
> (From update of attachment 342918 [details] [diff] [review])
> the bundle service is only used in InitDefaults, so could be moved there, so no
> longer in the normal startup path.

that is addressed in bug 342998

Comment 7

[Marco Bonardo [:mak]]

ops i attached the attachment number as bug number, the correct bug number is bug 459781

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 342918 [details] [diff] [review]
better

also the guid base could be moved to a smart-getter.

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 342918 [details] [diff] [review]
better

r=me w/ guid comment addressed

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch

GUIDBase moved to a getter

Comment 11

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/db7b8be0ba56

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv