455743 - Big /composer L10n cleanup

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Vlado Valastiak [:wladow]]

/composer is quite unfriendly and messy for L10n right now
.accesskeys and .labels don't have the same entity names

await quite large patches...

Comment 1

[Vlado Valastiak [:wladow]]

Attachment: editor part

the biggest part, rewrites all the inapropriate chosen .accesskey names in l10n dtds and also code in /composer folder.

- removes several unused entities
- removes entities
> -<!ENTITY increaseindentkb "=">
> -<!ENTITY decreaseindentkb "-">
not 100% sure about it, but I guess they're not used

Affected code is tidied for a better future readability.

Comment 2

[Vlado Valastiak [:wladow]]

Attachment: suite part

- fix one entity in mailnews prefs
- fix composer's entities used in debugQA

Comment 3

[Vlado Valastiak [:wladow]]

Attachment: mail part

patch for overlay files in /mail

tried to tidy up affected code a little bit for a better readability

Comment 4

[[e-mail]]

Comment on attachment 339102 [details] [diff] [review]
suite part

>         <menuitem label="&setFocusCmd.label;"
>-                  accesskey="&toolsetfocus.accesskey;"
>+                  accesskey="&setFocusCmd.accesskey;"

>+<!ENTITY setFocusCmd.accesskey "F">
There's no reason for debug menus to have access keys, so don't bother restoring this access key. r=me with that fixed.

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 339111 [details] [diff] [review]
mail part

r+ in general, just some nits: you've got quite a bit of trailing spaces at the ends of lines (in this piece and in the other two), and several places you slipped into XHTML pretending to be HTML mode, and put a space before />, which you don't need or want to do in XML. If you want to put all three parts into one patch that you run through http://beaufour.dk/jst-review/ to check for trailing whitespace (you can ignore the long lines where they're in the style of the ones around them) and tag me for review on that, I can give it a quick check and check it in.

Comment 6

[Vlado Valastiak [:wladow]]

Attachment: all together

Fixes:
1) removed setFocusCmd.accesskey from DebugQA ext.
2) removed space in " />" sequences
3) removed trailing whitespaces

Phil, thx for pointing this out. I'll try to watch TB and SM builds once you check this in to make sure everything goes smoothly.

Comment 7

[Vlado Valastiak [:wladow]]

Comment on attachment 341801 [details] [diff] [review]
all together

Oh wait, there're some checkins that are breaking things again. I'll make a new patch.

Comment 8

[Vlado Valastiak [:wladow]]

Attachment: all together against current tree

hopefully merge went well

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 341807 [details] [diff] [review]
all together against current tree

One wee nit, already fixed locally (I'm just waiting for healthier Thunderbird Mac tinderboxes to check in):

-<!ENTITY pasteColumns.accesskey "c">
+<!ENTITY pasteColumnsCmd.accesskey "C"

For want of a ">" the entire composer is lost ;)

Comment 10

[Vlado Valastiak [:wladow]]

(In reply to comment #9)
> -<!ENTITY pasteColumns.accesskey "c">
> +<!ENTITY pasteColumnsCmd.accesskey "C"
> 
> For want of a ">" the entire composer is lost ;)

Heh, I'm wondering how could this happen when it's defined correctly in the original patch and this one is just merged. Thx anyway.

Comment 11

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/b1da7109257a