455978 - need status and emergency brake UI for gloda

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

We want some very basic "emergency brake" UI affordance and possibly some status strings to give users some idea of what gloda's doing, and, on the off chance that there's some weird bug, disable it.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Here's a status message:

"Indexing folder $f from $account"

Gloda is a bit "nebulous" about what it's really doing and indexing of messages often happens so fast that we might as well just inform the person only when acting on a particular folder.

Still working on an e-brake...

Comment 2

[Magnus Melin [:mkmelin]]

With "..." i assume?
As i mentioned in some other similar bug, i think "from $account" is likely to sound odd in many cases, depending on what you name your account.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

> With "..." i assume?

Good point.

> As i mentioned in some other similar bug, i think "from $account" is likely to
> sound odd in many cases, depending on what you name your account.

Agreed. Bug 455812 is the other one.  Taking from your example there we can get the following:

 "$accountname - indexing messages in $folder..."

Comment 4

[Mark Banner (:standard8)]

Who's owning this? Due to the late strings, we need to be getting this in as soon as possible to help our localisers.

Comment 5

[Mark Banner (:standard8)]

Gloda has moved out to beta 2, so moving this out as well.

Comment 6

[David :Bienvenu]

What are our plans here? We're less than a week from the string freeze...

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Assigning to Bryan, as we need some prefs UI.

Andrew, seems like it would make sense to code up a patch with the status message that Bryan already suggested...

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

we should plenty of room in the adv. general preferences tab pane thanks to bug 456872.  Hopefully we could land this as we move others like bug 452890 into adv. general as well.

We can just use some kind of checkbox for the on/off state.  I'm not really sure what use for the string though.  This is just for the "testing" phase so we could go vague or be very experimental.

[x] Index Messages 

--- or ---

[x] Use Experimental Message Indexer
--- or ---
[x] Use Experimental Message Indexer (gloda)

Comment 9

[Magnus Melin [:mkmelin]]

(In reply to comment #8)
>  This is just for the "testing" phase so we could go vague or be very
> experimental.

There isn't going to be UI in the end?

If it is, then UI now seems redundant. On the other hand, I don't think that's what you meant and we do want UI. Would be good to use something that sticks and avoid renaming unnecessarily - we have to name it the next month or so anyways so... Of those options I'd prefer:
 [x] Index Messages 

Is gloda a global/account or folder option?

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

There might be room being able to turn the indexer on or off in the future, but I don't think this checkbox is going to be the best interface.  Right now we just need a temporary emergency brake in case gloda is really braking things.

I used less 'experimental' language so that translations could possibly be reused for a similar option.  Will attach in a second.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of the advanced user prefs w/ the gloda indexer option

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: 455978-v1.patch

Here's the patch that gets this temp preference in

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: 455978-v2.patch

Here's an updated version of this patch that is just a text change in the dtd file, with some better alignment as well.  

I removed the word "Global" as it seemed confusing after some review.

Now you get an option that looks like this:

  [x] Enable Message Indexer

Comment 14

[David :Bienvenu]

Comment on attachment 348050 [details] [diff] [review]
455978-v2.patch

this patch looks like it's ready for review - if that's not the case, Bryan, can you comment? thx!

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

I think it's ready to go in

Comment 16

[David :Bienvenu]

Comment on attachment 348050 [details] [diff] [review]
455978-v2.patch

I think Phil is not doing reviews this weekend, so I'll try this patch out.

Comment 17

[David :Bienvenu]

Comment on attachment 348050 [details] [diff] [review]
455978-v2.patch

I'll land this with the late-l10n keyord/status...

Comment 18

[Simon Paquet [:sipaq]]

Please inform mozilla.dev.l10n immediately about this checkin as mandated by https://wiki.mozilla.org/Thunderbird:Localization#Breaking_the_string_freeze

Otherwise localizers won't pick this up.