456014 - consider enabling mathml in thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Magnus Melin [:mkmelin]]

As discussed in bug 306128, mathml is the only only (?) remaining build difference causing rendering differences between a thunderbird gecko rv and the corresponding firefox gecko rv.

I made a mathml (linux) build to check the binary code size impact

 du -sk thunderbird_official
 29136   thunderbird_official

 du -sk thunderbird_mathml
 29484   thunderbird_mathml

So it's an additional 348 KiB, which is ~ a 1.2% total binary size increase.

Unfortunately mathml doesn't work with this build, at least not using it as mail start page, although i removed MOZ_MATHML= from here 
http://mxr.mozilla.org/comm-central/source/mail/confvars.sh#42

... and the build logs -DMOZ_MATHML=1

Used http://www.w3.org/Math/XSL/csmall2.xml to test, and that works fine on the seamonkey start page. 

What else could need changing/enabling?

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> What else could need changing/enabling?

Maybe mailnews.display.html_sanitizer.allowed_tags needs to have math added? (not sure why that wouldn't affect SM though) or maybe our content policy is blocking things.

Looking at nsContextMenu.js, we'll need to extend the code there in potentially a similar way to Firefox's version to allow view mathml source. I doubt that's another menu option, just a reworking of the existing option.

Comment 2

[Magnus Melin [:mkmelin]]

Correction, e.g. http://www.albany.edu/~hammond/gellmu/dmml.xml does work, although http://www.w3.org/Math/XSL/csmall2.xml doesn't.

Comment 3

[Magnus Melin [:mkmelin]]

ls -s *.tar.bz2

9992 thunderbird-3.0b1pre.en-US.linux-i686_mathml.tar.bz2
9932 thunderbird-3.0b1pre.en-US.linux-i686_official.tar.bz2

So download size would be up only 0.6%

Tested some more, so far only the one url from comment 0 haven't worked

ok http://www.w3.org/Math/XSL/pmathml2.xml
ok http://www.mozilla.org/projects/mathml/start.xhtml
ok http://www.mozilla.org/projects/mathml/demo/texvsmml.xhtml
ok http://www.albany.edu/~hammond/gellmu/rubymath.xml
ok http://www.mathtoweb.com/cgi-bin/mathtoweb_home.pl
ok http://www.physics.orst.edu/~rubin/CPUG/MathML/David/ThesisPaper.xml
ok http://www.physics.orst.edu/~rubin/CPUG/MathML/David/chapter08.xml

Comment 4

[Phil Ringnalda (:philor)]

It'd be nice if a subscription to http://golem.ph.utexas.edu/~distler/blog/rss2.xml (showing the web page rather than the summary) works - it wasn't quite right the first time I tried a MathML build, but I might have been confused by font issues (and for Windows, I think you need to package mathml.css).

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Ok, so it seems to work for everything but the first url I found... And a local file:// version of that also works so let's enable it.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 364341 [details] [diff] [review]
proposed fix

r=me with the other change to packages-static that I forgot about: "bin\res\dtd\xhtml11.dtd" should be "bin\res\dtd\*" so we get mathml.dtd (and any other dtd anyone happens to drop in there).

Comment 7

[Magnus Melin [:mkmelin]]

changeset:   2156:552c30b28151
http://hg.mozilla.org/comm-central/rev/552c30b28151

->FIXED