Closed
Bug 456303
Opened 16 years ago
Closed 15 years ago
Make Tabsposé keyboard-accessible
Categories
(Camino Graveyard :: Accessibility, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino2.0
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
References
Details
(Whiteboard: [camino-2.0])
Attachments
(1 file)
|
9.69 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
We need to make Tabsposé tab-accessible, and wire it in and out of the loop when it's shown and hidden.
|
||
Updated•16 years ago
|
Hardware: PC → All
Flags: camino2.0?
|
Assignee | |
Comment 1•15 years ago
|
||
After starting down the road of wiring it up into the existing tab loop, I realized that it's easier and less error-prone to just give it its own tab loop, since it hides everything else. That seems to make the OS happy, since the Tab Overview toolbar button gets stuck in the loop automagically (although with the same weird can't-tab-backward-into-it issue we have with the toolbar normally). I also tossed in a quick fix for bug 392466, since it looks like this is not going to be an NSControl for 2.0.
Assignee: nobody → stuart.morgan+bugzilla
Status: NEW → ASSIGNED
Attachment #408297 -
Flags: superreview?(mikepinkerton)
|
|
Assignee | |
Updated•15 years ago
|
Flags: camino2.0? → camino2.0+
Target Milestone: --- → Camino2.0
What is/are the trigger(s) for selecting the currently-focused tab?
|
|
Assignee | |
Comment 3•15 years ago
|
||
Space, as with buttons (e.g., the bookmark buttons).
|
||
Comment 4•15 years ago
|
||
Comment on attachment 408297 [details] [diff] [review] fix +- (void)setUpKeyViewLoopWithInitialIndex:(unsigned int)startIndex method needs a function-level comment. sr=pink
Attachment #408297 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Landed on CVS trunk and CAMINO_2_0_BRANCH with added comments.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
You need to log in
before you can comment on or make changes to this bug.
Description
•