If a user adds a bookmark and then edits the "Folder" field in the bookmark, the changes are committed even if the user selects "Cancel" in the bookmark editing dialog. This only happens for the "Folder" field and not "Tags" or "Title" there. This was seen in Stuart's build 20080918185520. Steps to Reproduce 1. Browse to a page (http://www.mozilla.org, for example). 2. Add a bookmark for it by clicking on the star in the right panel. 3. Click on the star in the right panel again to edit the bookmark. 4. Add "Blah" to the "Folder" field and select "Cancel". 5. Edit the bookmark again. Result: When the bookmark is edited for the second time, "Blah" will be in the Folder attribute even though the change was canceled. If this is tried with the "Tags" or "Title" fields, the data does not persist.
neil, can you take a look at this please?
I can take this one
Created attachment 340071 [details] [diff] [review] clear out the folder textbox the Folder field isn't used currently (separate bug), so we didn't have any code to init the text value when displaying the panel. So any text that was entered just stuck around. It really wasn't saved anywhere. We clear it now.
Verified with a build from 2:20 today.