456628 - Lots of dead links and redirects in debugQAMenuOverlay.xul

Status: RESOLVED DUPLICATE of bug 1258226

(SeaMonkey :: UI Design, defect)

Description

[Stefan [:stefanh]]

There are 10 dead links in QA/Debug and a bunch of redirects (Viewer Demos and XBL Test Suite are all OK):

http://www.mozilla.org/quality/browser/debugtc/bft_browser_imagemap.html
Response status code: 404
Response message: Not Found

http://www.libpng.org/pub/png/png-MagnoliaAlpha.html

http://www.mozilla.org/quality/browser/debugtc/bft_browser_html_mix3.html
Response status code: 404
Response message: Not Found

http://www.mozilla.org/quality/browser/debugtc/bft_browser_link.html
Response status code: 404
Response message: Not Found

http://www.mozilla.org
http://www.yahoo.com

http://www.netscape.com
Response status code: 301 -> 200
Response message: Moved Permanently -> OK (to http://netscape.aol.com)
http://www.excite.com

http://www.microsoft.com
Response status code: 302 -> 200
Response message: Found -> OK (redirected to http://www.microsoft.com/en/us/default.aspx)

http://www.city.net
Response status code: (N/A)
Response message: Can't connect to www.city.net:80 (Bad hostname 'www.city.net')
http://www.mirabilis.com

http://www.time.com
Response status code: 301 -> 200
Response message: Moved Permanently -> OK (to http://www.time.com/time/)

http://www.warnerbros.com
http://www.cnn.com

http://www.usatoday.com
Response status code: 403
Response message: Forbidden

http://www.disney.go.com
Response status code: 301 -> 200
Response message: Moved Permanently -> OK (to http://disney.go.com/index)

http://www.hotwired.com
Response status code: (N/A)
Response message: Can't connect to www.hotwired.com:80 (Bad hostname 'www.hotwired.com')

http://www.hotbot.com
Response status code: 302 -> 200
Response message: Found -> OK


Form Manager Samples - http://www.mozilla.org/wallet/samples/wallet.html
Response status code: 404
Response message: Not Found

chofmann's Browser Buster - http://webtools.mozilla.org/buster/
OK, but the link to Veritest on http://webtools.mozilla.org/buster/index.html is dead

QA menu:
http://www.seamonkey-project.org/start/

http://www.mozilla.org/quality/
Response status code: 302 -> 200
Response message: Found -> OK (redirected to http://quality.mozilla.org/)

https://bugzilla.mozilla.org/duplicates.cgi

http://www.mozilla.org/quality/bug-writing-guidelines.html
Response status code: 301 -> 200
Response message: Moved Permanently -> OK (to http://developer.mozilla.org/en/Bug_writing_guidelines)

https://bugzilla.mozilla.org/enter_bug.cgi?format=guided
https://bugzilla.mozilla.org/buglist.cgi?product=Core&product=SeaMonkey&chfieldfrom=0d&chfieldto=Now&chfield=%5BBug+creation%5D
http://hg.mozilla.org/comm-central/index.cgi/pushloghtml?startdate=24+hours+ago&enddate=now (not sure about the 'index.cgi' here)
http://hg.mozilla.org/mozilla-central/index.cgi/pushloghtml?startdate=24+hours+ago&enddate=now (not sure about the 'index.cgi' here)
http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey

http://www.mozilla.org/quality/smoketests/
Response status code: 301 -> (N/A)
Response message: Moved Permanently (to https://litmus.mozilla.org/)

http://www.mozilla.org/quality/precheckin-tests.html
Response status code: 404
Response message: Not Found

http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-trunk/

Comment 1

[Stefan [:stefanh]]

> http://www.hotbot.com
> Response status code: 302 -> 200
> Response message: Found -> OK

(for completeness) - redirected to http://www.hotbot.com/?&diktfc=EAC16EAC0A8C425B26F4CE2023C724A4F250D4898944

Comment 2

[Stefan [:stefanh]]

And resource:///res/strres-test.xul doesn't exists

Comment 3

[Stefan [:stefanh]]

Personally, I think that we should remove all the tests from the debug menu.

Comment 4

[Stefan [:stefanh]]

Attachment: Massive slaughter of debugQA menus

This is probably too much... It sort of feels like that. I doubt anyone uses this, though. I any case, I insist of at least removing the Verification menu ;)

Comment 5

[Stefan [:stefanh]]

Another possible solution that is not so drastic is to keep Viewer Demos, XBL Test Suite, XUL Test Suite and possibly chofmann's Browser Buster. It's just that... the tests are a bit old and if we keep we should be sure that they're useful for testers/developers.

Comment 6

[[e-mail]]

Comment on attachment 344746 [details] [diff] [review]
Massive slaughter of debugQA menus

You're right, it is too much :-P

Comment 7

[Stefan [:stefanh]]

ajschult, any ideas/suggestions of some links that would be handy for testers (other than the ones we have)?

Comment 8

[Andrew Schultz]

http://crash-stats.mozilla.com/ would be good.  Perhaps about:crashes in crashreporter-enabled builds.

Comment 9

[Stefan [:stefanh]]

(In reply to comment #8)
> http://crash-stats.mozilla.com/ would be good.  Perhaps about:crashes in
> crashreporter-enabled builds.

OK. What about stuff related to tests? We have a bunch of links to websites that I said I wanted to remove, but maybe they're good for smoketests? Or maybe we don't check websites?

Comment 10

[Andrew Schultz]

Right.  I rarely methodically visit a list of websites (I suspect most people don't use the verification menu)... I suspect we get reasonable coverage from people visiting whatever sites they visit.  There are a couple visit-this-website tests in the litmus testrun.

The other (non-website) tests are somewhat superseded by the automated tests (more extensive and they catch problems a tester might miss looking at the page).

FWIW, usatoday and hotwire both load ok for me (hotwire redirects).

Comment 11

[Robert Kaiser]

I think we should have some links on how to perform tests, and "get involved" should changed to point to http://www.seamonkey-project.org/dev/get-involved

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> http://www.mozilla.org/quality/browser/debugtc/bft_browser_imagemap.html
> http://www.mozilla.org/quality/browser/debugtc/bft_browser_html_mix3.html
> http://www.mozilla.org/quality/browser/debugtc/bft_browser_link.html

These (at least) are still available at http://www-archive.mozilla.org/.
Do we want to get rid of the menu items or to bring the pages back online ?

Another option, if useful at all, could be to move (all) these items/links to a page on http://www.seamonkey-project.org/ !? (with only 1 link to it in the menu)
At least, that would be easier than to have to open the (sub-)menu for each link !

Comment 13

[Robert Kaiser]

The real question IMHO is not if they are 404 or not but how helpful they are for usual SeaMonkey QAers.

Comment 14

[Stefan [:stefanh]]

So, how about nuking the tests but keeping the (working) www links? Is that too much?

Comment 15

[Stefan [:stefanh]]

(In reply to comment #14)
> So, how about nuking the tests but keeping the (working) www links? Is that too
> much?

What I mean is keeping the mozilla.org, yahoo.com etc links

Comment 16

[Stefan [:stefanh]]

Attachment: New version, keep verification menu

OK, so this one adds some stuff to the QA menu (crash-stats, about:crashes etc). I kept the Verification menu (added/removed some websites). I also re-arranged the QA menu a bit.

Comment 17

[Robert Kaiser]

I like this patch!
If it gets fast review, it might be a good idea to squeeze it into 2.0a2 still.

Comment 18

[[e-mail]]

Comment on attachment 350685 [details] [diff] [review]
New version, keep verification menu

>+  var enabled = "";
>+  try {
>+    enabled = iniParser.getString("Crash Reporter", "Enabled");
>+  }
>+  catch(e) {}
>+  if (enabled == "1") // Show menuitem
>+    document.getElementById("submittedReports").removeAttribute("hidden");
Just put all of this inside the try/catch.

>-        <menu label="Viewer Demos">
>-        <menu label="XBL Test Suite">
>-        <menu label="XUL Test Suite">
Why did you remove these?

>+      <menupopup id="qaMenuPopup" onpopupshowing="return updateMyReportsMenuitem();">
This only needs to be called once when the overlay loads, not every time you open the menu...

>+                  oncommand="openTopWin('http://developer.mozilla.org/en/Bug_writing_guidelines');"/>
Should that be en or En? I'm never sure :-(

Comment 19

[Stefan [:stefanh]]

(In reply to comment #18)
> (From update of attachment 350685 [details] [diff] [review])
> >+  var enabled = "";
> >+  try {
> >+    enabled = iniParser.getString("Crash Reporter", "Enabled");
> >+  }
> >+  catch(e) {}
> >+  if (enabled == "1") // Show menuitem
> >+    document.getElementById("submittedReports").removeAttribute("hidden");
> Just put all of this inside the try/catch.

OK.

> 
> >-        <menu label="Viewer Demos">
> >-        <menu label="XBL Test Suite">
> >-        <menu label="XUL Test Suite">
> Why did you remove these?

I doubt they're useful anymore (comment #10). But I could be wrong, of course. If we think that our testers/hackers needs them, we should keep them - otherwise not, I think.

> 
> >+      <menupopup id="qaMenuPopup" onpopupshowing="return updateMyReportsMenuitem();">
> This only needs to be called once when the overlay loads, not every time you
> open the menu...

Oops, you're right. Have to be an event listener then, I guess.

> 
> >+                  oncommand="openTopWin('http://developer.mozilla.org/en/Bug_writing_guidelines');"/>
> Should that be en or En? I'm never sure :-(

Now when I looked at the page, I realize it should be "En".

Comment 20

[Stefan [:stefanh]]

Attachment: New attempt

Fixed comments (try/catch, event listener and "En"). The thing is that I personally never use these tests/demos, so I might be biased here. Imo the website links might be useful to some extent if people want to test how common websites looks in SeaMonkey. So I updated those a bit (added a few sites that are among the top-ranked, removed a few etc). But if testers/devs find the tests/demos useful we should keep them, of course.

Comment 21

[[e-mail]]

(In reply to comment #10)
> The other (non-website) tests are somewhat superseded by the automated tests
How about we rename them to X[BU]L Demos instead?

Comment 22

[Andrew Schultz]

(In reply to comment #21)
> How about we rename them to X[BU]L Demos instead?

Ya, that's at least truth in advertising.  :)  But is the Debug menu the right place for demos?

Comment 23

[Stefan [:stefanh]]

Attachment: Unbitrottened

Some bitrot in the latest patch - this is fixed in this version.

Comment 24

[Stefan [:stefanh]]

(In reply to comment #11)
> I think we should have some links on how to perform tests, and "get involved"
> should changed to point to http://www.seamonkey-project.org/dev/get-involved

Actually, I see now that I somehow link to /start - but I'll change to the above URI.

Comment 25

[Robert Kaiser]

Stefan, ping?

Comment 26

[Stefan [:stefanh]]

Well, the patch is there. But we probably need a discussion on how the menus should look.

Comment 27

[Robert Kaiser]

(In reply to comment #26)
> Well, the patch is there. But we probably need a discussion on how the menus
> should look.

Please ask for review and let's try to get this in so that we have at least the broken stuff fixed. Let's fix things to be even better in a followup, please. This has stalled for too long, IMHO.

Comment 28

[Philip Chee]

Stefanh: ping?

Comment 29

[Stefan [:stefanh]]

(In reply to comment #28)
> Stefanh: ping?

See comment #26. IIRC the patch has bitrottened and some more things should probably be removed. I didn't asked for review on the second patch since I felt thing had stalled anyway. Feel free to take it if you want this in fast since I won't have any time for this until May.