456761 - URL Bar has no "level" attribute indicating secure URLs

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Pardal Freudenthal (:ShareBird)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3pre) Gecko/2008091306 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3pre) Gecko/2008091306 Firefox/3.0.3

After the patch for Bug 448939 landed, the URL bar has lost the "level" attribute. This "level" attribute is very important because:

1. Firefox 3.0 has removed the "yellow" URL bar indication for secure URLs, but many users are using customization CSS code to bring back this colors indicators following the tendencies from Google Chrome and Internet Explorer. Without this attribute no CSS codes are possible to do this.

2. Firefox 3.0 has implemented the Security UI based on two things: A colored button inside the urlbar and "Larry". I'm sure most of FF users has never meet "Larry", and the only visible indicator for a secure URL is indeed the button. With the level attribute it's possible to third party themes to indicate the secure level for a location in many other ways. How the indication looks should be a skin choice.



Reproducible: Always




The level attribute doesn't hurt if maintained and is very useful, so please let it be...

Comment 1

[Dave Townsend [:mossop]]

I tend to agree, this is a regression in how themes can customise the look of the url bar based on the security of the site.

Comment 2

[Simon Bünzli]

Instead of re-adding that attribute, I'd rather see a fix for bug 436170 (CSS sibling selector doesn't work with anonymous content), though.

Comment 3

[Pardal Freudenthal (:ShareBird)]

But that bug is something a bit vague and I don't believe it will be fixed before FF 3.1.

This one is easier to fix with an absolutely no-risk patch. And if it will be implemented similar as I proposed here: https://bugzilla.mozilla.org/show_bug.cgi?id=456790#c2 we will have one more possibility with the addition from the "toplevel" attribute.

For me particularly, this bug is very important, since I don't use any colored buttons to indicate the security state from URLs. And believe me, I've expended a lot of time trying to bring this colored button's concept into my theme (www.silvermel.net), with dozen of urlbar draw and redraw to come to the conclusion it doesn't fit anyway. So the only way I have to indicate those status is using the textbox background like in FF 2.0. Without this fix I'm afraid I'll run into security issues... So, I need this fix ASAP. And as I said before, it doesn't hurt, will not affect anything in Firefox and will offer more possibilities to third party themes.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Dao, can we add this back in? I agree that it's the type of thing that, amongst other things, will help others experiment with better security UI mechanisms.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Comment 6

[Pardal Freudenthal (:ShareBird)]

(In reply to comment #5)
> Created an attachment (id=348634) [details]
> patch

Dão, would you mind adding a "toplevel" attribute as in https://bugzilla.mozilla.org/show_bug.cgi?id=456790#c2 ?
This would make possible to differenciate better the states.
Thanks

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Dão, would you mind adding a "toplevel" attribute as in
> https://bugzilla.mozilla.org/show_bug.cgi?id=456790#c2 ?
> This would make possible to differenciate better the states.

That's beyond this bug. You should discuss this with Johnathan in bug 456790.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348634 [details] [diff] [review]
patch

a1.9.1b2=beltzner, would be good to get this in for themers

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fe7fadd4d230