Closed Bug 457033 Opened 11 years ago Closed 11 years ago

WinCE No FatalAppExit function in Shunt

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfe, Unassigned)

References

Details

(Keywords: mobile)

Attachments

(1 file, 1 obsolete file)

Attached patch v.1 patch (obsolete) — Splinter Review
Combined implementing a FatalAppExit function in Mozilla WinCE Shunt with changing the API call to explicitly call the WCHAR version of this function.
Attachment #340366 - Flags: review?(pavlov)
why the change to

-
-// Not defined anywhere
-typedef INT_PTR intptr_t;


do you need a define for the function you are adding to the shunt?

Also, please separate out the lcms stuff from the shunt code so that we can land separately.
Just Mozilla Shunt Library changes to add FatalAppExitW function.
Attachment #340366 - Attachment is obsolete: true
Attachment #340375 - Flags: review?(doug.turner)
Attachment #340366 - Flags: review?(pavlov)
Summary: WinCE No FatalAppExit function → WinCE No FatalAppExit function in Shunt
Attachment #340375 - Flags: review?(doug.turner) → review+
Comment on attachment 340375 [details] [diff] [review]
v.2 patch - contains only shunt library changes

i will ignore the first change in the patch.

We should remove the hard coded string when bug 456813 is fixed.

We do not need to put anything in the defines because this function is defined, just not implemented on the device/emulator or in the libs.
92cc665e9b84
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 457047
do we still need the change to:

  modules/lcms/src/cmserr.c
wolfe?
Yes, for this bug to work, we need to change the call to function MessageBox() to be an explicit call to MessageBoxW().
You need to log in before you can comment on or make changes to this bug.