457033 - WinCE No FatalAppExit function in Shunt

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[John Wolfe (:wolfe)]

Attachment: v.1 patch

Combined implementing a FatalAppExit function in Mozilla WinCE Shunt with changing the API call to explicitly call the WCHAR version of this function.

Comment 1

[Doug Turner (:dougt)]

why the change to

-
-// Not defined anywhere
-typedef INT_PTR intptr_t;


do you need a define for the function you are adding to the shunt?

Also, please separate out the lcms stuff from the shunt code so that we can land separately.

Comment 2

[John Wolfe (:wolfe)]

Attachment: v.2 patch - contains only shunt library changes

Just Mozilla Shunt Library changes to add FatalAppExitW function.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 340375 [details] [diff] [review]
v.2 patch - contains only shunt library changes

i will ignore the first change in the patch.

We should remove the hard coded string when bug 456813 is fixed.

We do not need to put anything in the defines because this function is defined, just not implemented on the device/emulator or in the libs.

Comment 4

[Doug Turner (:dougt)]

92cc665e9b84

Comment 5

[Doug Turner (:dougt)]

do we still need the change to:

  modules/lcms/src/cmserr.c

Comment 6

[Doug Turner (:dougt)]

wolfe?

Comment 7

[John Wolfe (:wolfe)]

Yes, for this bug to work, we need to change the call to function MessageBox() to be an explicit call to MessageBoxW().