Closed Bug 457206 Opened 16 years ago Closed 15 years ago

Lightning/Sunbird 0.9 fail to display a whole caldav calendar because of one (misformed?) event that didn't bring 0.8 into trouble

Categories

(Calendar :: Provider: CalDAV, defect)

x86
All
defect
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 481825

People

(Reporter: sga, Unassigned)

Details

Attachments

(3 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.3) Gecko/2008092510 Ubuntu/8.04 (hardy) Firefox/3.0.3
Build Identifier: lightning 0.9 build 2008091718

Lightning and Sunbird 0.9 fail to display a caldav calendar containing the attached event, but 0.8 versions are displaying this calendar including the (misformed?) event.



Reproducible: Always

Steps to Reproduce:
1. import .ics file to caldav server
2. add caldav calendar to lightning/sunbird
Actual Results:  
No events from the added calendar are displayed

Expected Results:  
All events should be displayed

The propably misformed event contains a RECURRENCE-ID but is no recurring event. This seems to bring sunbird/lightning 0.9 into trouble.

When the RECURRENCE-ID is removed everything runs fine, but this is no option since older sunbird/lightning clients seem to have "corrupted" many items in our companys calendaring system (DAViCal).


Setting lightning to calendar.debug.log and calendar.debug.log.verbose has not improved the error logging, the only error messages are:

Warning: Fehler beim Lesen von Daten für Kalender: 104. Allerdings ist dieser Fehler wahrscheinlich vernachlässigbar, daher versucht das Programm fortzufahren. Fehlercode: 0x80004005. Beschreibung: failed to retrieve item

Warning: Fehler beim Lesen von Daten für Kalender: 104. Allerdings ist dieser Fehler wahrscheinlich vernachlässigbar, daher versucht das Programm fortzufahren. Fehlercode: READ_FAILED. Beschreibung:
The correct event ics.
Attachment #340555 - Attachment is obsolete: true
(In reply to comment #0)
> Steps to Reproduce:
> 1. import .ics file to caldav server
> 2. add caldav calendar to lightning/sunbird
> Actual Results:  
> No events from the added calendar are displayed

If you see no events at all, then this is rather strange, since the ics parser filters out parentless items (i.e. items with RECURRENCE-ID, but no master item in the same VCALENDAR), because we still cannot cope with them. Nevertheless all other items are parsed.

> When the RECURRENCE-ID is removed everything runs fine, but this is no option
> since older sunbird/lightning clients seem to have "corrupted" many items in
> our companys calendaring system (DAViCal).
Why do you think lightning is the cause? AFAIK ever has only stored complete items (master + overridden items), no parentless items like you see.

> Setting lightning to calendar.debug.log and calendar.debug.log.verbose has not
> improved the error logging, the only error messages are:
> 
> Warning: Fehler beim Lesen von Daten fĂĽr Kalender: 104. Allerdings ist dieser
> Fehler wahrscheinlich vernachlässigbar, daher versucht das Programm
> fortzufahren. Fehlercode: 0x80004005. Beschreibung: failed to retrieve item
> 
> Warning: Fehler beim Lesen von Daten fĂĽr Kalender: 104. Allerdings ist dieser
> Fehler wahrscheinlich vernachlässigbar, daher versucht das Programm
> fortzufahren. Fehlercode: READ_FAILED. Beschreibung:
no logs in the js console?
No more logs in the console.

I think lightning is the problem because lightning 0.8 always displays all events (with NO error in the console), but lightning 0.9 only shows alle events when i delete the "RECURRENCE-ID" line from the event on the caldav server.

So there must have been changes in lightning causing this.
I believe this is a dupe of bug 455260
(In reply to comment #4)

> > When the RECURRENCE-ID is removed everything runs fine, but this is no option
> > since older sunbird/lightning clients seem to have "corrupted" many items in
> > our companys calendaring system (DAViCal).
> Why do you think lightning is the cause? AFAIK ever has only stored complete
> items (master + overridden items), no parentless items like you see.

I doubt that older versions have caused that data corruption, i.e. cut master items.

(In reply to comment #5)
> I believe this is a dupe of bug 455260

Yes, it sounds like, but I am seriously asking why, because the ics-parser doesn't break on them, but leaves those out to

<http://mxr.mozilla.org/comm-central/source/calendar/base/public/calIIcsParser.idl#94>
I just applied the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=455260

So know i see more in the log. As far as i can see parsing of all overridden items fails, but the master is displayed without any problems.


Now i tried to reproduce such items, but i can't!

When i change a single occurence of a recurring event the singe changed occurence gets stored in the same .ics file on the caldav server.
But the already existing occurences that got changed are stored in their own .ics file. So it seems like lightning 0.9 is not able to parse items with a reccurence-id if they are not in the same .ics like their master item, but lightning 0.8 is able to do this.

Now the question seems to be what behaviour is right.
I also get this error and have been searching for a couple of months for a solution.  I've followed this through and have verbose logging but I can't identify which event is causing problems.  I did not import an ics calendar though.

My provider is Zimbra, installed on our network.  I'm using TB 2.0.0.19 and Lightning 0.9.  I have access to a shared calendar on Zimbra, which displays the symptoms described, and a personal calendar (also on Zimbra), which doesn't.  I did have similar issues with my personal calendar but they seem to have disappeared.

Strangely, I have found on one occasion that deleting a lot of old entries from the shared calendar makes the symptoms disappear for a while (Zimbra has no automatic purging of old entries).  

Also, some users have Lightning 0.8 and don't experience this problem.
Hi,

I want to say, that I have also this problem. So u are not the only user with this problem. On my google search, I found many other users with this problem:

http://www.scalix.com/forums/viewtopic.php?p=54645
http://www.sunbird-kalender.de/forum/viewtopic.php?f=13&t=2594&start=0
http://www.scheduleworld.com/jforum/posts/list/2376.page
http://www.google.com/support/forum/p/Calendar/thread?tid=53d6cca555f9682a&hl=en

I can also provide your with logs, or ics files, or a caldav account with this problem. 

I also tested nightly build from 2008-10-08 (last builds for thunderbird 2), but the bugs is still present there.
Please try this (in a new profile!!!) with Thunderbird 3 and Lightning 1.0pre. I've fixed a bug that prevented them from being displayed.
I tested with new Thunderbird Beta 2 and the current build from http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/linux-xpi/lightning.xpi

It works.. I don't get a error message.

Can somebody make a backport or can u say me, what was the changes (link to the revision)? Or is Thundebird 3 final in the nearly next time?
SOGo <http://www.scalableogo.org/about/overview.html> offers a so called Mozilla Lightning 0.9.2 (Inverse Edition). It is based on Lightning 0.9 and contains several backported bug fixes from 1.0pre. But I don't know if the discussed issue is fixed there. You could test yourself but keep in mind this version is not supported by the Calendar Project.
thanks for this hint, but the bug is still present in this "edition".

it will be helpful, when Philipp can provide the link to the revisions at http://hg.mozilla.org/
thanks! I patched to parts of my calDavCalendar.js and it works :-)

For others who are interested in this I made a patch (while the original is a little bit different to version 0.9.

I also add the final resulting file for those who can not handle patch utils:

Thhe file have to replaced in
[PROFILE-FOLDER]/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/js/
Attached patch patch for lightning 0.9 — — Splinter Review
Attached file patched file for lightning 0.9 (obsolete) —
Ludovic, you may be interested in adding this backported patch to your 0.9.3
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
I'm sorry to say that this patched file did not work at all for me!  None of my calendars load now.  Previously only one of them failed to load completely.
hmm.. I'm not sure but I think, that it is because of the error handling.. it just skip loading the entries who can not be loaded? So, if u have very mush entries who cannot be parsed, it skip all of them.... Or I'm wrong?

So, it is not the right solution to skip them...?!
I'm not sure to be honest.  It would be better to hear some more feedback from others that have tried the patch.  It may be a peculiarity of Zimbra, which is the e-mail/calendar server I use.  I think a lot of people experiencing this problem are using Google calendar.

I note that TB3b2 seems to cope a lot better.  It would be handy to know how to identify the dodgy entries.
Attachment #371055 - Attachment is obsolete: true
Attached file patched file for lightning 0.9 (obsolete) —
sorry ppls.. I uploaded the wrong file. now the right file with the applied patch.
(In reply to comment #18)
> Ludovic, you may be interested in adding this backported patch to your 0.9.3
> 
> *** This bug has been marked as a duplicate of bug 481825 ***

In fact, I've already applied the fix from #455260. I'll look at this patch to see if it is any different / better.

#455260 proved to work very well for us.
Im really sorry! I uploaded the unpatched version. Now I have verified before ;-)
Attachment #371701 - Attachment is obsolete: true
YEEESSSSS!  Sorry - a bit excited.  Works a treat.  Well done and thanks for that - it's been bugging me for ages.
FYI, we've added the fix in the Inverse Edition. It'll be part of the 0.9.4 release.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: