nuke dead nsGlobalWindow::ConvertCharset

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

Tracking

Trunk
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

11 years ago
Posted patch nuke convertcharset (obsolete) — Splinter Review
Attachment #340641 - Flags: review?(bzbarsky)
Attachment #340641 - Flags: review?(bzbarsky) → review+
Comment on attachment 340641 [details] [diff] [review]
nuke convertcharset

Nice catch.  Can we nuke the nsICharsetConverterManager include as well?
(Assignee)

Comment 2

11 years ago
pushed 41bb2af34a9b
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
backed out for now
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So how come this got backed out?
(Assignee)

Comment 5

11 years ago
i took out the include and that broke the build. It'll push it tomorrow.
(Assignee)

Comment 6

11 years ago
Posted patch removed include (obsolete) — Splinter Review
Fixed patch, ready for checkin
Attachment #340641 - Attachment is obsolete: true
(Assignee)

Comment 7

11 years ago
this is what i meant to upload
Attachment #341499 - Attachment is obsolete: true
(Assignee)

Comment 8

11 years ago
pushed http://hg.mozilla.org/mozilla-central/rev/edadac8d8a50
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
Assignee: nobody → tglek
You need to log in before you can comment on or make changes to this bug.