457898 - top crash [@ JS_BeginRequest ] -- DTToolbarFF.dll@0x2a4a7

Status: RESOLVED DUPLICATE of bug 459850

(Firefox :: Extension Compatibility, defect)

Description

[chris hofmann]

There seems to be a pretty big uptick in recent reported startup crashes with a stack that contains the DTToolbarFF.dll which appears to belong to 
http://www.daemon-toolbar.com/faq#What_is_DAEMON_Tools_Toolbar

Its currently the #5 ranked crash for fx3.0.1

Stack looks like

0  	js3250.dll  	JS_BeginRequest  	 mozilla/js/src/jsapi.c:881
1 	js3250.dll 	JS_ResumeRequest 	mozilla/js/src/jsapi.c:998
2 	xul.dll 	XPCJSContextStack::Pop 	mozilla/js/src/xpconnect/src/xpcthreadcontext.cpp:118
3 	js3250.dll 	JS_SuspendRequest 	
4 	xul.dll 	nsXPCWrappedJS::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp:559
5 	xul.dll 	PrepareAndDispatch 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp:114
6 	xul.dll 	SharedStub 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp:141
7 	DTToolbarFF.dll 	DTToolbarFF.dll@0x2a4a7

Comment 1

[Samuel Sidler (old account; do not CC)]

The stack now (below) doesn't show DTToolbarFF.dll in it and it's now the #4 topcrash. That being said, the modules for each crash I looked at include DTToolbarFF.dll in their Module list, which implies that it's still part of the issue.

Use this link to see a bunch of reports: http://crash-stats.mozilla.com/report/list?product=Firefox&branch=1.9&version=Firefox%3A3.0.3&query_search=signature&query_type=contains&query=&date=&range_value=1&range_unit=weeks&do_query=1&signature=JS_BeginRequest

Note that I'm seeing, specifically, version 1.0.0.1 and 1.0.0.11 of that DLL crashing.

Rey, do we have any contacts here? If not, can we quickly make some and work with them to see what the problem is? If this is on our end, we should know that and fix it soon.

--

Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	js3250.dll 	JS_BeginRequest 	mozilla/js/src/jsapi.c:881
1 	js3250.dll 	JS_ResumeRequest 	mozilla/js/src/jsapi.c:998
2 	xul.dll 	XPCJSContextStack::Pop 	mozilla/js/src/xpconnect/src/xpcthreadcontext.cpp:118
3 	xul.dll 	nsCxPusher::Pop 	mozilla/content/base/src/nsContentUtils.cpp:2686
4 	xul.dll 	nsTextBoxFrame::UpdateAccesskey 	mozilla/layout/xul/base/src/nsTextBoxFrame.cpp:252
5 	xul.dll 	nsAsyncAccesskeyUpdate::ReflowFinished 	mozilla/layout/xul/base/src/nsTextBoxFrame.cpp:222
6 	xul.dll 	PresShell::HandlePostedReflowCallbacks 	mozilla/layout/base/nsPresShell.cpp:4471
7 	xul.dll 	PresShell::DidDoReflow 	mozilla/layout/base/nsPresShell.cpp:6213
8 	xul.dll 	PresShell::ProcessReflowCommands 	mozilla/layout/base/nsPresShell.cpp:6401

Comment 2

[Rey Bango]

I don't have a contact but I've gone to their site and asked them to email us ASAP. I also explained to them this is an urgent issue and if we don't hear from them, then we would need to consider blocklisting the toolbar to protect Mozilla users from instability. I also made sure to explain to them that blocklisting is an absolute last resort and that we want to work with them to correct the crashes.

If we've not heard back from them by EOW, then we should revisit our options.

Comment 3

[Samuel Sidler (old account; do not CC)]

Err, no need to do this. I've already contacted them. See bug 459850.

Comment 4

[Rey Bango]

The toolbar is set to be blocklisted per this bug https://bugzilla.mozilla.org/show_bug.cgi?id=459850

Comment 5

[chris hofmann]

143 total crashes for JS_BeginRequest on 20090819-crashdata.csv
31 start up crashes inside 3 minutes
222.148 (days) total uptime for 126 of these crashes where user crashed within the last year 
2538.83 (minutes) avg time since last crash 
17  number of bogus time-since-last-crash reported for this signature 

JS_BeginRequest signature breakdown
signature distribution
       1
signature list
 143 JS_BeginRequest

os breakdown
  45 JS_BeginRequest Windows NT 5.1.2600 Service Pack 3
  37 JS_BeginRequest Windows NT 5.1.2600 Service Pack 2
  19 JS_BeginRequest Windows NT 6.0.6001 Service Pack 1
  15 JS_BeginRequest Windows NT 5.1.2600
   5 JS_BeginRequest Windows NT 6.0.6000
   4 JS_BeginRequest Windows NT 5.1.2600 Service Pack 1
   3 JS_BeginRequest Windows NT 6.0.6002 Service Pack 2
   3 JS_BeginRequest Mac OS X 10.5.8 9L30
   2 JS_BeginRequest Mac OS X 10.5.8 9L31a
   1 JS_BeginRequest Windows NT 6.1.7100
   1 JS_BeginRequest Windows NT 5.2.3790 Service Pack 2
   1 JS_BeginRequest Windows NT 5.1.2600 Szervizcsomag 3
   1 JS_BeginRequest Windows NT 5.1.2600 Szervizcsomag 1
   1 JS_BeginRequest Windows NT 5.1.2600 Service Pack 3, v.3264
   1 JS_BeginRequest Windows NT 5.1.2600 Service Pack 2, v.2096
   1 JS_BeginRequest Windows NT 5.1.2600 Service Pack 1, v.1105
   1 JS_BeginRequest Windows NT 5.1.2600 Dodatek Service Pack 3
   1 JS_BeginRequest Windows NT 5.1.2600 Dodatek Service Pack 2
   1 JS_BeginRequest Mac OS X 10.4.9 8P135

distribution of versions where the crash was found on 20090819-crashdata.csv
  63 Firefox 3.5.2
  59 Firefox 3.0.13
   5 Firefox 3.5
   3 Firefox 3.5.1
   2 Firefox 3.0.4
   2 Firefox 3.0.12
   2 Firefox 3.0.11
   2 Firefox 3.0.10
   1 Firefox 3.0.8
   1 Firefox 3.0.7
   1 Firefox 3.0.6
   1 Firefox 3.0.5
   1 Firefox 3.0

Comment 6

[Jesse Ruderman on Windows]

Very few or none of the recent JS_BeginRequest crashes are due to DTToolbar.  I think the blocklisting took care of those crashes.  Any other JS_BeginRequest crashes are separate bugs.