Handle even more .mozconfig files in .hgignore

RESOLVED WONTFIX

Status

--
minor
RESOLVED WONTFIX
11 years ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 341245 [details] [diff] [review]
Patch

Bug 389826 added .mozconfig, .mozconfig.mk and .mozconfig.out files to .hgignore.  I tend to keep at least a couple of .mozconfig files named such as .mozconfig-dbg and .mozconfig-opt for debug and optimized builds, and when building an optimized version, for example, I do:

cp .mozconfig-opt .mozconfig
make -f client.mk build

I think we can further improve the .mozconfig handling in .hgignore to enable such use cases.  See the attached patch for the approach I'm proposing.
Attachment #341245 - Flags: review?(benjamin)
for this use, I would personally recommend expanding *your* hgrc file to have those additional mozconfig ignores, rather than do in tree.

existing .mozconfig ignores are good enough, and we do have the MOZCONFIG environ var that is also referenced for the multiple config uses.
(Assignee)

Comment 2

11 years ago
(In reply to comment #1)
> for this use, I would personally recommend expanding *your* hgrc file to have
> those additional mozconfig ignores, rather than do in tree.
> 
> existing .mozconfig ignores are good enough, and we do have the MOZCONFIG
> environ var that is also referenced for the multiple config uses.

This is mostly a convenience issue, and I'm not that much urged to get this into the tree.  So, I'll wait and see what Benjamin thinks here, and if he feels the same way, we can WONTFIX it.  :-)

Comment 3

11 years ago
Comment on attachment 341245 [details] [diff] [review]
Patch

Let's WONTFIX this
Attachment #341245 - Flags: review?(benjamin) → review-

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.