458078 - sunbird-bin shouldn't try and link directly with libtracemalloc anymore

Status: VERIFIED FIXED

(Calendar :: Build Config, defect)

Description

[Philippe M. Chiasson (:gozer)]

+++ This bug was initially created as a clone of Bug #458075 +++

Don't try and directly link with tracemalloc anymore

As part of work on bug 435122, the need for the final executable to link directly to libtracemalloc has been removed.

The side effect of this change is that when building Sunbird with --enable-shared, generating sunbird-bin tries to link with -ltracemalloc, and that will fail. With static builds, we just end up double-linking against tracemalloc.

Attached patch simply removes the special case for libtracemalloc

Sunbird suffers from a similar problem.

Comment 1

[Philippe M. Chiasson (:gozer)]

Attachment: Don't try and directly link with tracemalloc anymore

Comment 2

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 341331 [details] [diff] [review]
Don't try and directly link with tracemalloc anymore

Looks good, r=philipp

Comment 3

[Philippe M. Chiasson (:gozer)]

Comment on attachment 341331 [details] [diff] [review]
Don't try and directly link with tracemalloc anymore

changeset:   481:b47711026af1
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Wed Oct 01 16:32:31 2008 -0400
summary:     Bug 458078. It isn't necessary to directly link against libtracemalloc anymore. r=philipp

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".