Closed Bug 458078 Opened 16 years ago Closed 16 years ago

sunbird-bin shouldn't try and link directly with libtracemalloc anymore

Categories

(Calendar :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: gozer, Assigned: gozer)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #458075 +++

Don't try and directly link with tracemalloc anymore

As part of work on bug 435122, the need for the final executable to link directly to libtracemalloc has been removed.

The side effect of this change is that when building Sunbird with --enable-shared, generating sunbird-bin tries to link with -ltracemalloc, and that will fail. With static builds, we just end up double-linking against tracemalloc.

Attached patch simply removes the special case for libtracemalloc

Sunbird suffers from a similar problem.
Comment on attachment 341331 [details] [diff] [review]
Don't try and directly link with tracemalloc anymore

Looks good, r=philipp
Attachment #341331 - Flags: review+
Comment on attachment 341331 [details] [diff] [review]
Don't try and directly link with tracemalloc anymore

changeset:   481:b47711026af1
tag:         tip
user:        Philippe M. Chiasson <gozer@mozillamessaging.com>
date:        Wed Oct 01 16:32:31 2008 -0400
summary:     Bug 458078. It isn't necessary to directly link against libtracemalloc anymore. r=philipp
Attachment #341331 - Attachment filename: tracemalloc.diff → [checked in] tracemalloc.diff
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Assignee: nobody → gozer
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.