458081 - Too easy opening control Control and Tab bars...

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oleg Romashin (:romaxa)]

Currently it is very easy to open or start C&T bars opening while panning...

I think we should make C&T bars opening if mouse movement very close to horizontal. For example approximate angle should be <=30 grad to start bars opening...

Comment 1

[Madhava Enros [:madhava]]

I know that Johnath wrote a patch at one point to constrain side-to-side movement -- is that still in?  I'd rather not make the bars just not come out if there's too much up or down -- that makes it less physical, and makes it more of a gestural UI than a physical space-based UI.  Either way, we do need do something so that it's not quite so easy to accidentally end up with a sidebar open.  A quicker feedback loop should help with this somewhat -- i.e., if the page moves _as_ you're dragging rather than after as much of a delay -- in that you can correct as you see a bit of the sidebar start to come into view.

Comment 2

[Johnathan Nightingale [:johnath]]

(In reply to comment #1)
> I know that Johnath wrote a patch at one point to constrain side-to-side
> movement -- is that still in?

You're talking about bug 445716, which does appear to still be in, here:

http://mxr.mozilla.org/mobile-browser/source/chrome/content/deckbrowser.xml#1312

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I'd like to get "unified panning" in place before trying to band-aid this problem more than we do.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: side bar gutter

this makes things better as a stop gap

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

landing mb-bleanup has bitrotted the patch

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 345798 [details] [diff] [review]
side bar gutter

This has really bit-rotted.  Do we still want something like it?

Comment 7

[Stuart Parmenter]

this is implemented basically correctly now -- we'll do additional work in bug 464063

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

our side bars have been adjusted many times, they are working well now as of beta3